fix: isolate TracesSampler callback failures - #5545
Open
elkampu wants to merge 2 commits into
Open
Conversation
Co-Authored-By: GPT-5.6 Sol <noreply@openai.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5545 +/- ##
==========================================
- Coverage 74.70% 74.53% -0.17%
==========================================
Files 515 515
Lines 18948 18963 +15
Branches 3696 3694 -2
==========================================
- Hits 14155 14134 -21
- Misses 3909 3943 +34
- Partials 884 886 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the help @elkampu!
This looks 99% of the way there. I've just made one small suggestion.
Co-Authored-By: GPT-6 Astra <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the
TracesSamplerportion of #5535.What changed
TracesSamplerfailures at the user-callback boundary and logTracesSampler callback failed.at error levelTracesSampleRatenullon callback failure so the native SDK can use its normal fallbacksample_rateclient-report accountingValidation
dotnet test test/Sentry.Tests/Sentry.Tests.csproj -c Release -f net10.0 --filter "FullyQualifiedName~StartTransaction_TracesSampler" --no-restore— 10/10 passeddotnet build src/Sentry/Sentry.csproj -c Release -f net10.0 --no-restore— passed, 0 warnings/errorsdotnet build src/Sentry/Sentry.csproj -c Release -f net10.0-android36.0 --no-restore— passed, 0 warnings/errorsdotnet format whitespace --folder --verify-no-changesfor the five changed files — passedgit diff --check— passedCocoa compilation requires macOS; the Cocoa change is limited to the same user-delegate recovery boundary and will be exercised by the repository's macOS CI.