Skip to content

chore: Add view.authenticate, deprecated in favor of view - #702

Open
alexander-alderman-webb wants to merge 2 commits into
mainfrom
webb/view.authenticate
Open

alexander-alderman-webb wants to merge 2 commits into
mainfrom
webb/view.authenticate

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Unlike view, view.authenticate is not documented in the devdocs.

The latter is set by the Python SDK in https://github.com/getsentry/sentry-python/blob/1ca032605a337eb1dee696b594c28d7620e93ddf/sentry_sdk/consts.py#L1364.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 12, 2026 11:54am UTC

Request Review

@github-actions

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • Add view.authenticate, deprecated in favor of view by alexander-alderman-webb in #702

🤖 This preview updates automatically when you update the PR.

elramen
elramen previously approved these changes Oct 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4798564. Configure here.

Comment thread model/op/web_server.json
@elramen
elramen dismissed their stale review October 12, 2026 11:46

too quick

@elramen elramen left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does view by itself really cover authentication?

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor Author

@elramen The span name is "authenticate" in the case of Python, so I don't think we need the redundancy

This branch was successfully deployed

1 active deployment
Preview — 25b4e856 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants