Repository navigation
feat(attributes): Add http.request.duration - #697
Conversation
In getsentry/relay#4874, Relay started setting this attribute for NEL reports, but it was never added to conventions. Fixes INGEST-1259.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
| "key": "http.request.duration", | ||
| "brief": "The duration of a HTTP request, in milliseconds.", | ||
| "type": "integer", | ||
| "apply_scrubbing": { |
There was a problem hiding this comment.
could we add an "additional_context" field that this attribute is set by Relay? Just to make sure SDKs don't think they need to set this, as this usually should just be the duration of the respective http.server span.
There was a problem hiding this comment.
Is "this attribute is set by Relay" enough or should I add more detail?
There was a problem hiding this comment.
all good, just some indication that it's not an SDK concern (fwiw, we should get better at this with #659 or something similar). Thanks for adding!
This branch was successfully deployed
4 participants
Description
In getsentry/relay#4874, Relay started setting this attribute for NEL reports, but it was never added to conventions.
Fixes INGEST-1259.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)