Skip to content

fix(attributes): Remove any as valid attribute type - #677

Merged
Lms24 merged 2 commits into
mainfrom
lms/fix-remove-any
Oct 6, 2026
Merged

Lms24 merged 2 commits into
mainfrom
lms/fix-remove-any

Conversation

@Lms24

@Lms24 Lms24 commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

#662 accidentally left any as a valid attribute type in the schema, which stems from a previous iteration of the PR. This cleans it up.

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 6, 2026 8:10am UTC

Request Review

@Lms24
Lms24 requested review from a team and nsdeschenes as code owners October 6, 2026 08:00
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (attributes) Remove any as valid attribute type by Lms24 in #677

Internal Changes 🔧

  • (deps) Bump postcss-selector-parser from 7.1.4 to 7.1.6 by dependabot in #676

🤖 This preview updates automatically when you update the PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d372b91. Configure here.

"type": {
"description": "The type of the attribute value",
"enum": ["string", "boolean", "integer", "double", "string[]", "boolean[]", "integer[]", "double[]", "any"]
"enum": ["string", "boolean", "integer", "double", "string[]", "boolean[]", "integer[]", "double[]"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover any type branch

Low Severity

Removing any from the type enum leaves an unreachable oneOf branch that still matches const: "any". That branch can never validate now and is leftover from the previous iteration this change is cleaning up.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d372b91. Configure here.

@Lms24
Lms24 merged commit e0875d0 into main Oct 6, 2026
18 checks passed
@Lms24
Lms24 deleted the lms/fix-remove-any branch October 6, 2026 08:13

This branch was successfully deployed

1 active deployment
Preview — d372b91c Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants