Repository navigation
feat(attributes): Add AWS service instrumentation attributes - #672
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Attributes
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
pabloDeputter
marked this pull request as ready for review
October 5, 2026 12:21
pabloDeputter
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
mjq and
nsdeschenes
as code owners
October 5, 2026 12:21
alexander-alderman-webb
approved these changes
Oct 6, 2026
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
Contributor
There was a problem hiding this comment.
These are in OTel so it's okay to add these.
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [644], |
Contributor
There was a problem hiding this comment.
Wrong PR number
Contributor
|
Please wait 2 days before merging to let others look over this PR. |
pabloDeputter
added a commit
that referenced
this pull request
Oct 6, 2026
Lms24
approved these changes
Oct 6, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice! The one non-OTel attribute looks fine and in line with other .arn attributes we already have.
pabloDeputter
force-pushed
the
pablo/add-aws-instrumentation-attributes
branch
from
October 6, 2026 13:11
9a0065d to
d6a4941
Compare
4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following AWS service attributes:
aws.s3.copy_source,aws.s3.delete,aws.s3.key,aws.s3.part_number,aws.s3.upload_id.aws.dynamodb.attributes_to_get.aws.sqs.queue.url.aws.s3.object_sizefile.sizecan be used for this: whole-object size;GETwith a range or part useshttp.response.body.size.aws.step_functions.execution.arn: step-functions execution ARN from a request or response.