Repository navigation
feat(attributes): align MCP conventions and OAuth client identity - #671
Merged
Merged
Conversation
Co-Authored-By: GPT-6 (Codex) <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Attributes
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: GPT-6 (Codex) <codex@openai.com>
Co-Authored-By: GPT-6 (Codex) <codex@openai.com>
betegon
marked this pull request as ready for review
October 5, 2026 18:03
betegon
requested review from
a team,
Lms24,
alexander-alderman-webb,
cleptric,
mjq and
nsdeschenes
as code owners
October 5, 2026 18:03
obostjancic
approved these changes
Oct 6, 2026
alexander-alderman-webb
requested changes
Oct 6, 2026
alexander-alderman-webb
approved these changes
Oct 7, 2026
This was referenced Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidate the MCP attribute contract before SDKs adopt canonical OpenTelemetry keys. Add
gen_ai.prompt.variable.<key>and the Sentry-specificmcp.auth.client.name, and correct metadata that currently treats a transport implementation name or resource URI scheme as a network attribute.Provenance is based on OpenTelemetry MCP conventions at e07f4eb and its MCP registry. These conventions are in Development; the repository imports core semantic conventions v1.44.0.
mcp.method.name,mcp.protocol.version,mcp.session.id, andmcp.resource.uri. Keep their OTel flags; clarify that operations need not belong to a session.is_in_otel: false.mcp.serverand directional notification operations as Sentry categorizations.mcp.transportpreserves custom class names and is not an alias ofnetwork.transport.mcp.resource.protocolidentifies the resource URI scheme, independently of the server's network protocol. Remove both incorrect deprecations and their aliases in both directions while keeping valid network aliases. Progress current/total accept fractional values, as required by the MCP progress specification. Request IDs correlate requests and responses without requiring session-scoped uniqueness; readiness remains specific to the legacy handshake.OAuth
client_namecomes from client registration metadata, not MCPclientInfo. It remains distinct frommcp.client.nameand is omitted when unavailable.Generated JavaScript/Python exports and search metadata are included. This PR must be published before canonical SDK attribute adoption #25060 and OAuth capture #24508 can merge. The mechanical SDK imports #25059 use existing published constants and can proceed independently.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.