Skip to content

fix(worker): Bump taskbroker-client to 0.20.26 - #695

Merged
evanh merged 1 commit into
mainfrom
evanh/fix/bump-taskbroker-client
Sep 24, 2026
Merged

evanh merged 1 commit into
mainfrom
evanh/fix/bump-taskbroker-client

Conversation

@evanh

@evanh evanh commented Sep 23, 2026

Copy link
Copy Markdown
Member

0.20.26 sends the broker hostname alone as the :authority instead of host:port, which is what the Cloud Service Mesh route matches on (getsentry/taskbroker#795). The s4s2 task-launchpad-push-worker pool can't be routed through envoy until launchpad is on it — getsentry/ops#23716 does that for getsentry, which is already on 0.20.26, and deliberately leaves launchpad out.

BatchPushTaskWorker folded into PushTaskWorker when batching became the default in getsentry/taskbroker#751, so src/launchpad/worker/config.py moves to PushTaskWorker and drops update_in_batches=True. Every other kwarg at that call site is still supported.

The lock also moves sentry-arroyo 2.39.2 → 2.44.1, sentry-sdk 2.61.1 → 2.70.0, msgpack 1.1.2 → 1.2.2 and adds prometheus-client, all forced by 0.20.26's own floors.

0.20.26 sends the broker hostname alone as the :authority instead of host:port, which is what the
mesh route matches on. The s4s2 launchpad push pool cannot be routed through envoy until launchpad
is on it (getsentry/ops#23716 covers getsentry, which already is).

BatchPushTaskWorker folded into PushTaskWorker when batching became the default in
getsentry/taskbroker#751, so the call site moves over and drops update_in_batches. The lock also
pulls arroyo, the sentry SDK, msgpack and prometheus-client up to the client's floors.
@evanh

evanh commented Sep 23, 2026

Copy link
Copy Markdown
Member Author
$ uv run pytest tests -q --ignore=tests/e2e --ignore=tests/integration
3 failed, 369 passed in 39.39s

$ uv run pytest tests/unit/test_worker_config.py -q
9 passed

The three are pre-existing on main — test_universal_apk, test_get_apksigner_certs and test_aggregate_symbols_mixed_modules fail identically with the diff stashed and 0.20.6 reinstalled (they want android/swift tooling that isn't on this machine).

Collection failed before the config.py change with ImportError: cannot import name 'BatchPushTaskWorker', which is how the rename surfaced.

$ uv run python -c "import importlib.metadata as m; print(m.version('taskbroker-client'))"
0.20.26
$ uv lock --check
Resolved 138 packages

Heads up on a likely conflict: your local evanh/fix/cleanup-args branch deletes src/launchpad/worker/config.py, which is the file this PR edits. Whichever lands second will need a hand.

@sentry

sentry Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
HackerNews com.emergetools.hackernews 3.8 (1) Release

Android

🔗 App Name App ID Version Configuration
Hacker News com.emergetools.hackernews 1.0.2 (13) Release

⚙️ launchpad-test-android Build Distribution Settings

@sentry

sentry Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Size Analysis

2 components analyzed

iOS Builds

Name Configuration Version Download Size Install Size
HackerNews (iOS)
com.emergetools.hackernews
Release 3.8 (1) 6.5 MB (N/A) 9.7 MB (N/A)

Android Builds

Name Configuration Version Download Size Uncompressed Size
Hacker News (Android)
com.emergetools.hackernews
Release 1.0.2 (13) 2.9 MB (N/A) 6.6 MB (N/A)

Configure launchpad-test-ios status check rules

@evanh
evanh requested a review from a team September 23, 2026 17:10
@evanh
evanh merged commit 7d7d803 into main Sep 24, 2026
28 checks passed
@evanh
evanh deleted the evanh/fix/bump-taskbroker-client branch September 24, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants