chore(lint): Enforce anti-slop rules - #170
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gricha
marked this pull request as ready for review
August 23, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor Dillon Mulroy's anti-slop Oxlint plugin and enforce all 15 generic rules across the owned repository. Oxlint and its plugin API are pinned together at 1.79.0, while generated agent state and the vendored plugin itself are excluded from self-linting. Lint entrypoints use the existing
tsxloader so the TypeScript plugin also works under the repository's Node 20 CI runtime.Making the rules mandatory surfaced 274 existing violations. The accompanying refactor replaces module mocks and unchecked boundary assertions with typed dependency seams, runtime schemas, and reusable guards while preserving CLI and plugin behavior. Reviewers may want to start with
.oxlintrc.jsonandtools/oxlint/anti-slop/, then inspect the resolver, Git, CLI, and plugin-store seams. The Effect-specific rule remains unregistered because this repository has no direct Effect dependency.The final tree passes all 1,138 tests, typechecking, AST policies, and isolated Docker example/plugin lifecycle QA.