Skip to content

feat: add github copilot target - #166

Open
mishamilovidov wants to merge 3 commits into
getsentry:mainfrom
mishamilovidov:milovido-adobe-copilot-adapter-adoption
Open

feat: add github copilot target#166
mishamilovidov wants to merge 3 commits into
getsentry:mainfrom
mishamilovidov:milovido-adobe-copilot-adapter-adoption

Conversation

@mishamilovidov

@mishamilovidov mishamilovidov commented Aug 21, 2026

Copy link
Copy Markdown

Summary

Add GitHub Copilot CLI and Desktop support with native skill discovery and safe MCP configuration in user and project scopes.

Changes

  • Add a copilot target with COPILOT_HOME, .mcp.json, and .github/mcp.json fallback support.
  • Preserve unmanaged MCP entries and reuse Claude-compatible serialization for stable shared project configuration.
  • Enforce mode 0600 for user MCP files on POSIX and cover drift repair, path precedence, and unchanged writes.

Testing

  • pnpm check (296 library tests and 853 host tests).
  • pnpm --dir docs build.
  • pnpm qa:example.
  • pnpm qa:plugins.
  • Non-root Docker lifecycle tests with Copilot CLI 1.0.80 for user and project configuration.

Related Issues

Notes

GitHub Copilot accepts the implicit stdio shape used by Claude, so both targets can share .mcp.json without ordering churn. This change keeps direct MCP pruning, instruction overlays, hooks, subagents, plugins, and secret storage out of scope.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@mishamilovidov is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Add user and project MCP configuration for GitHub Copilot CLI and Desktop while preserving unmanaged native entries. Reuse Claude-compatible project serialization and protect the user MCP file with mode 0600 on POSIX systems.
@mishamilovidov
mishamilovidov force-pushed the milovido-adobe-copilot-adapter-adoption branch from c738fbe to 056e9db Compare August 21, 2026 23:31
@mishamilovidov
mishamilovidov marked this pull request as ready for review August 21, 2026 23:31
@github-actions github-actions Bot added the risk: high PR risk score: high label Aug 21, 2026
Comment thread packages/dotagents/src/targets/mcp-writer.ts Outdated
Comment thread packages/dotagents/src/targets/mcp-writer.ts
Preserve fallback MCP entries when Claude and Copilot converge on `.mcp.json`. Recover if a mode check races with external file deletion.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3c3871e. Configure here.

Comment thread packages/dotagents/src/targets/mcp-writer.ts
Comment thread packages/dotagents/src/targets/mcp-writer.ts
Propagate preferred-file write errors instead of reporting them as fallback read failures. Recreate JSONC state if the config file disappears during reconciliation.
@mishamilovidov

mishamilovidov commented Aug 22, 2026

Copy link
Copy Markdown
Author

Hey @gricha and @dcramer. I'm not able to add you as reviewers directly as an outside contributor, but this should be ready for review now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high PR risk score: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support GitHub Copilot CLI and Desktop

1 participant