Repository navigation
ci(node): Bump Node pins to 22.23.4 and 24.22.1 - #1666
Closed
sentry-junior[bot] wants to merge 2 commits into
Closed
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Geoff Goldsmith <geoff.goldsmith@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Node 24.22.1 rejects zero-length zstd input with "unexpected end of file", so the all-zero TRDIFF10 fixture failed before reaching the SHA-256 check. Compress empty blocks so the patch is valid and the test still exercises the hash mismatch path.
Member
|
Work has ceased on this repo and it will be archived very soon. We are in the process of moving PRs and issues over to getsentry/toolkit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the exact CI Node pins from 22.23.1 to 22.23.4 and from 24.18.0 to 24.22.1. That covers
NODE_VERSION_22/NODE_VERSION_24and the one literal pin inpr-risk-labels-test.yml. These are the October 2026 security releases for the eMudhra/emSign CA compromise. They update the bundled root store to NSS 3.131.1 and reject TLS chains that contain the compromised keys. Both releases are newer than the nodejs/node#64004 fix that the pins exist for, so the comments explaining the pins still hold.NODE_VERSION_20(20.20.2) is unchanged. Node 20 has no release with this fix, and it stays in the matrix as the WASM-SQLite floor.Refs VULN-3216. Release notes: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
via Geoff Goldsmith.
--
View Junior Session [Sentry]