fix(init): require explicit zero workflow exit - #1451
Merged
Conversation
Treat malformed successful workflow responses as failures so missing exit metadata cannot make sentry init return a false zero.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
sentry initaccept a terminal workflow result as successful only when it explicitly reportsstatus: "success"andresult.exitCode: 0.Previously, a successful response with no
resultor noexitCodepassed the truthiness check and could print the success handoff with process exit 0. The CLI now treats that as malformed, surfaces a specificWizardError, and exits nonzero. Existing nonzero workflow-to-CLI exit mappings are unchanged.This makes the process exit status a reliable black-box signal for the init smoke harness.
Compatibility
This intentionally stops accepting terminal success payloads that omit
exitCode. The current wizard success output already returnsexitCode: 0.The draft #1406 also touches
handleFinalResult; merge order will require rebasing whichever PR lands second.Test plan
git diff --checkdarwin-arm64binary buildRollout
The paired API-owned smoke is getsentry/cli-init-api#249. Once this lands, bump its pinned CLI SHA so malformed successful workflow responses cannot produce a false-green smoke result.