fix(telemetry): Silence CliError for process exit code 1 - #1449
Open
sentry[bot] wants to merge 1 commit into
Open
fix(telemetry): Silence CliError for process exit code 1#1449sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sentry local runandsentry monitor runcommands propagate child process exit codes asCliError("Process exited with code N"). Previously, these errors were not explicitly silenced inclassifySilenced()insrc/lib/error-reporting.ts, leading to them being captured and sent to Sentry.This resulted in a significant amount of telemetry noise (CLI-20G), as these errors represent expected failures of user-provided scripts rather than bugs in the CLI itself.
This change adds a new
SilenceReasoncalled"process_exit"and modifiesclassifySilenced()to return this reason forCliErrorinstances whose message starts with "Process exited with code". This ensures that these expected errors are no longer sent to Sentry, reducing noise and improving the signal-to-noise ratio of our telemetry.Fixes CLI-20G
This PR was automatically generated by Sentry. You can adjust this setting at any time.