feat(dashboard): render complete dashboards as sixel - #1410
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
github-actions
Bot
added
risk: high
Member
|
Jared, I see no reason for mixing sixel widgets and ASCII ones. If we have sixel everything we have should be possible to render in sixel |
Member
|
Jared? |
Rework the opt-in sixel timeseries rendering (#1231) around a single resolution-independent chart core instead of a standalone sixel-only renderer. chart-core.ts builds a ChartModel from a TimeseriesResult and rasterizes it into an RGBA canvas at a caller-chosen resolution. The sixel path (pixel resolution) is now a thin wrapper over the core, and the ASCII renderer shares the same categorical palette, so both outputs agree on hue and stacking. Output target picks the resolution upfront. Opt-in via --sixel / SENTRY_DASHBOARD_SIXEL=1 / displayType timeseries_sixel; falls back to text when the terminal lacks support. Closes #1231
Address review feedback on the sixel timeseries rendering: - Pull sixel-eligible widgets out of the side-by-side framebuffer and render them full-width after the character grid. A DCS image advances the cursor by many rows, so composing it into a shared terminal row trampled the widget's own borders and any neighbor on those rows. - Exclude categorical_bar from sixel: the chart core only models time-bucket columns, so categorical widgets keep the ASCII per-category renderer instead of being drawn as the wrong viz. - Downsample dense series to the pixel budget in rasterizeChart, so ranges with more buckets than ~half the canvas width no longer clip their tail off-canvas (mirrors the ASCII sparkline path). - Use the shared EscapeType for the local esc state in fitToWidth. Adds tests for the categorical exclusion, standalone-block layout, and dense-series downsampling.
When sixel-eligible widgets are stripped out of the framebuffer, the remaining widgets kept their original `layout.y`, so `renderGrid` still allocated blank bands for the removed rows and the sixel images were always appended after the whole grid (changing vertical order). Compress `layout.y` values by dense rank while preserving relative order within the same original band, so the grid packs contiguously from y=0 with no holes and no reordering of left/right widgets on the same row.
The previous dense-rank compression only renumbered `y` values and ignored `layout.h`. Widgets that were stacked (`y_new = y_prev + h_prev`) collapsed to consecutive integers and overlapped. Pack by accumulating the tallest height in each original y-band so the next band starts immediately below the previous tallest widget.
Detect widgets whose start y lies inside another widget's span (the common tall-left + short-right pattern). When the layout is staggered, skip packing and keep the original y values so the grid is rendered exactly as the dashboard author laid it out. Staggered packing is out of scope for this opt-in experimental path.
BYK
force-pushed
the
feat/sixel-shared-renderer
branch
from
August 21, 2026 22:24
4a1ee6c to
4a61b5a
Compare
BYK
changed the title
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 71ada2b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1231.
dashboard view --sixelnow renders the complete dashboard into one Sixel canvas when terminal geometry is known, preserving the original widget grid. It renders timeseries, categorical bars, scalar values, tables, text, errors, and unsupported states with a single pixel renderer, so capable terminals never mix ASCII widgets with Sixel graphics.The command always falls back to the complete character dashboard when Sixel capability or terminal cell geometry is unavailable.
The chart core remains resolution-independent, downsamples dense time series, preserves the muted gray
Otherseries, and provides compact tick labels.Verification
pnpm run typecheckpnpm run lintpnpm run test:unit(9,260 passed; 16 skipped)Coverage includes categorical bars, scalar/table/text/error/unsupported widgets, adjacent widget positioning, dense-series tails, and the no-geometry ASCII fallback.