Skip to content

ci: upgrade macos-14 runners to macos-15 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuarli wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

ci: upgrade macos-14 runners to macos-15 #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-xcframework.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

jobs:
build:
runs-on: macos-14
runs-on: macos-15

steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build xcframeworks
run: bash build.sh

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
10 changes: 5 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,34 @@

jobs:
build:
runs-on: macos-14
runs-on: macos-15

@cursor cursor Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned Xcode missing on macos-15

High Severity

Jobs now run on macos-15 but still select /Applications/Xcode_15.4.app, which is not installed on that image. The xcode-select step fails immediately, so pull request builds, XCFramework builds, and the release workflow cannot complete.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 7eed22d. Configure here.


steps:
- name: Checkout code
Comment on lines 8 to 13

@sentry sentry Bot Oct 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflows specify using Xcode_15.4.app on macos-15 runners, but this version of Xcode is likely unavailable, which will cause the jobs to fail.
Severity: CRITICAL

Suggested Fix

Verify the available Xcode versions on the macos-15 runner image. Update the xcode-version input in the affected workflow jobs to a version confirmed to be installed on macos-15, which is likely a version of Xcode 16.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: .github/workflows/build.yml#L8-L13

Potential issue: The GitHub Actions workflows specify using `Xcode_15.4.app` on
`macos-15` runners. However, it is likely that the `macos-15` runner images provided by
GitHub do not include this version of Xcode, and may only contain Xcode 16.x versions.
If `Xcode_15.4.app` is not installed on the runner, the `xcode-select` command will
fail, causing the build and release jobs to fail. The pull request description's note to
check compatibility suggests this is a known risk. This issue affects multiple build
jobs across different workflows, including the critical release pipeline.

Also affects:

  • .github/workflows/build.yml:22~27
  • .github/workflows/build.yml:50~55
  • .github/workflows/build.yml:64~69
  • .github/workflows/build.yml:78~83
  • .github/workflows/build-xcframework.yml:8~13
  • .github/workflows/release.yaml:8~13

Did we get this right? 👍 / 👎 to inform future reviews.

uses: actions/checkout@v2
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build TestApp
run: cd Examples && xcodebuild build -scheme DemoApp -destination 'generic/platform=iOS Simulator' -project DemoApp/DemoApp.xcodeproj
- name: Build Snapshotting
run: xcodebuild build -scheme Snapshotting -sdk iphonesimulator -destination 'generic/platform=iOS Simulator'
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk iphonesimulator -destination 'generic/platform=iOS Simulator'
build-tvos:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: macos-14
runs-on: macos-15

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build PreviewGallery
run: xcodebuild build -scheme PreviewGallery -sdk appletvsimulator -destination 'generic/platform=tvOS Simulator'
- name: Build Snapshotting
run: xcodebuild build -scheme Snapshotting -sdk appletvsimulator -destination 'generic/platform=tvOS Simulator'
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk appletvsimulator -destination 'generic/platform=tvOS Simulator'
build-visionos:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: macos-15

steps:
Expand All @@ -49,43 +49,43 @@
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk xrsimulator -destination 'generic/platform=visionOS Simulator'
build-watchos:
runs-on: macos-14
runs-on: macos-15

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build Test Watch App
run: cd Examples && xcodebuild build -scheme 'Demo Watch App' -sdk watchsimulator -destination 'generic/platform=watchOS Simulator' -project DemoApp/DemoApp.xcodeproj CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO
- name: Build Snapshotting
run: xcodebuild build -scheme Snapshotting -sdk watchsimulator -destination 'generic/platform=watchOS Simulator'
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk watchsimulator -destination 'generic/platform=watchOS Simulator'
build-macos:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: macos-14
runs-on: macos-15

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build PreviewGallery
run: xcodebuild build -scheme PreviewGallery -sdk macosx -destination 'generic/platform=macOS'
- name: Build Snapshotting
run: xcodebuild build -scheme Snapshotting -sdk macosx -destination 'generic/platform=macOS'
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk macosx -destination 'generic/platform=macOS'
build-macos-catalyst:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: macos-14
runs-on: macos-15
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build PreviewGallery
run: xcodebuild build -scheme PreviewGallery -sdk macosx -destination 'platform=macOS,variant=Mac Catalyst'
- name: Build Snapshotting
run: xcodebuild build -scheme Snapshotting -sdk macosx -destination 'platform=macOS,variant=Mac Catalyst'
- name: Build SnapshottingTests
run: xcodebuild build -scheme SnapshottingTests -sdk macosx -destination 'platform=macOS,variant=Mac Catalyst'

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,26 @@

jobs:
release:
runs-on: macos-14
runs-on: macos-15

steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Xcode select
run: sudo xcode-select -s '/Applications/Xcode_15.4.app/Contents/Developer'
- name: Build xcframeworks
run: bash build.sh
- name: Zip xcframeworks
run: |
for framework_path in XCFrameworks/*.xcframework
do
framework="$(basename "$framework_path")"
(cd XCFrameworks && zip -r "../$framework.zip" "$framework")
done
- name: Upload Artifact
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844
if: startsWith(github.ref, 'refs/tags/')
with:
files: "*.xcframework.zip"
body:
Release ${{ github.ref }}
Expand Down
Loading