v0.5.1: no default auto-fallback + search-enabled model picker + blue panel borders - #12
Merged
Merged
Conversation
… blue panel borders
RECTOR live-EVAL feedback (3 fixes):
1. Auto-detect sets ONLY the primary, not the fallback (amazon-bedrock/nova-2-lite
was being auto-set as the fallback — too opinionated). The frontier-escalation
mechanism (fallback field + retry→fallback pipeline) remains; the user sets
the fallback explicitly via /vision fallback. autoDetectDefaults returns only
{provider, model}; session_start wiring + notify updated; tests T62 + the
fallback-preserve test updated; README updated.
2. Search-enabled vision model picker (matches pi /model + /settings UX). New
VisionModelPicker component (Container): blue DynamicBorder + title + search
Input + SelectList.setFilter (fuzzy) + DynamicBorder. Used by buildModelSubmenu
(the /vision panel Vision-model row) + pickVisionModel (/vision model no-arg +
ctrl+shift+i hotkey, TUI mode). Non-TUI falls back to ctx.ui.select. Picker
tests updated to mock ctx.ui.custom.
3. /vision panel wrapped with blue DynamicBorder lines above + below (matches
/settings visual framing). +DynamicBorder + Spacer imports.
350 tests pass, typecheck clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.5.1 — RECTOR live-EVAL feedback (3 fixes)
Three fixes from RECTOR's live EVAL of v0.5.0:
1. Auto-detect sets ONLY the primary, not the fallback
v0.5.0 auto-detected a frontier fallback (
amazon-bedrock/amazon.nova-2-lite-v1:0) — too opinionated. v0.5.1:autoDetectDefaultsreturns only{provider, model}; the fallback is NOT auto-populated. The frontier-escalation mechanism stays (thefallbackfield + v0.2.x retry→fallback pipeline); the user sets it explicitly via/vision fallback <provider/model>. Tests T62 + the fallback-preserve test updated. README updated.2. Search-enabled vision model picker (matches pi
/model+/settingsUX)New
VisionModelPickercomponent (extendsContainer): blueDynamicBorder+ title + searchInput+SelectList.setFilter(fuzzy filtering as you type) +DynamicBorder. Used by:buildModelSubmenu(the/visionpanel's "Vision model" row → Enter opens the picker)pickVisionModel(/vision modelno-arg +ctrl+shift+ihotkey, TUI mode)Non-TUI (RPC/print) falls back to
ctx.ui.select(no search). Input routing: Escape → cancel; ↑↓/Enter → SelectList; typing → Input →setFilter. Picker tests updated to mockctx.ui.custom.3.
/visionpanel gets blue border lines (matches/settings)Wrapped the
/visionsettings panel withDynamicBorder((text) => theme.fg("accent", text))above + below (withSpacer(1)between) — the same visual framing pi's/settingsuses.DynamicBorderimported from@earendil-works/pi-coding-agent,Spacerfrom@earendil-works/pi-tui.Tests
350 tests pass (unchanged count — the 3 picker tests were updated, not added/removed). Typecheck clean.
Constraints
Clean-room, no AI attribution.
lib/defaults.tsstill pure + deterministic. TheVisionModelPickeris a private class inextensions/vision.ts(TUI-only).