feat(cursor): set the default cursor size at the marked position - #889
Conversation
1.95 was a 30% bump over 1.5 and still left the size slider's handle near the left edge, which read as too small for effects that are part of the product. 3.6 sits at 47% of the 1.5-6 range, a 98 px arrow in a 1080p export.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe default cursor size in ChangesCursor default
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to Projects using the cursor-size fallback will get the intended larger default, placing the slider near its midpoint. No concrete regression is identified, so the change is mergeable with minimal risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up to #881, which landed a 30% bump (1.5 to 1.95) and still left the size slider's handle near the left edge. The mark on the slider is the target:
cursor.sizegoes to 3.6, which is 47% along the 1.5-6 range. A 41 px arrow in a 1080p export becomes 98 px.Same one value as before,
DEFAULT_PROJECT_APPEARANCE.cursor.sizeinsrc/lib/projectDefaults.ts. The 1.5 floor inSETTING_BOUNDSstays, so only the factory default moved.Related issue
Refs #881
Type of change
Release impact
Desktop impact
Screenshots / video
Size slider, 1.5-6 range,
pct = (value - 1.5) / 4.5:Testing
npx vitest --runover the five files that read the cursor defaults:editorSettings,stylePresets,cursorThemes,projectPersistence,nativeCompositorStore. 152 tests green. No test pins the default, so nothing to update.npx tsc --noEmitandnpx tsc -p tsconfig.test.json --noEmit, both clean.Full suite left to CI; the diff is one constant and one comment block.
Summary by CodeRabbit