Skip to content

feat(cursor): set the default cursor size at the marked position - #889

Merged
EtienneLescot merged 1 commit into
mainfrom
feat/cursor-default-size
Sep 28, 2026
Merged

EtienneLescot merged 1 commit into
mainfrom
feat/cursor-default-size

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #881, which landed a 30% bump (1.5 to 1.95) and still left the size slider's handle near the left edge. The mark on the slider is the target: cursor.size goes to 3.6, which is 47% along the 1.5-6 range. A 41 px arrow in a 1080p export becomes 98 px.

Same one value as before, DEFAULT_PROJECT_APPEARANCE.cursor.size in src/lib/projectDefaults.ts. The 1.5 floor in SETTING_BOUNDS stays, so only the factory default moved.

Related issue

Refs #881

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

Size slider, 1.5-6 range, pct = (value - 1.5) / 4.5:

default handle arrow height in a 1080p export
1.5 0% 41 px
1.95 (#881) 10% 53 px
3.6 (this PR) 47% 98 px

Testing

  • npx vitest --run over the five files that read the cursor defaults: editorSettings, stylePresets, cursorThemes, projectPersistence, nativeCompositorStore. 152 tests green. No test pins the default, so nothing to update.
  • npx tsc --noEmit and npx tsc -p tsconfig.test.json --noEmit, both clean.

Full suite left to CI; the diff is one constant and one comment block.

Summary by CodeRabbit

  • Updates
    • The default cursor size is now larger, making it more visible in projects that use the standard appearance settings. Existing custom cursor sizes are unaffected.

1.95 was a 30% bump over 1.5 and still left the size slider's handle near the left edge, which read as too small for effects that are part of the product. 3.6 sits at 47% of the 1.5-6 range, a 98 px arrow in a 1080p export.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6d6e9be3-e81e-4786-a847-abb20ebc9418

📥 Commits

Reviewing files that changed from the base of the PR and between 4f35409 and 429dcfc.

📒 Files selected for processing (1)
  • src/lib/projectDefaults.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The default cursor size in DEFAULT_PROJECT_APPEARANCE.cursor changes from 1.95 to 3.6. The accompanying comments are revised.

Changes

Cursor default

Layer / File(s) Summary
Update cursor size default
src/lib/projectDefaults.ts
The default cursor size changes from 1.95 to 3.6, and its explanatory comments are revised.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Suggested reviewers: my-denia

Merge Risk: ⚪ Minimal · up to 429dc

Projects using the cursor-size fallback will get the intended larger default, placing the slider near its midpoint. No concrete regression is identified, so the change is mergeable with minimal risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: setting the default cursor size at the marked slider position.
Description check ✅ Passed The description includes all required sections. It explains the change, references issue #881, identifies the change type and release impact, states platform impact, provides visual sizing details, an…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit 9fe809b into main Sep 28, 2026
19 checks passed
@EtienneLescot
EtienneLescot deleted the feat/cursor-default-size branch September 28, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant