Repository navigation
Update CI actions to latest major versions, upload .jar - #106
Merged
Merged
Conversation
- older actions versions now showing warnings on Actions run history that they are running with a newer version of Node (v24) than they are written for (v20). - the "Upload libs artifact" uploads the "build/libs" as a zip but it (should) only contain the release jar file, so upload only the jar file to simplify release prep.
lognaturel
approved these changes
Oct 30, 2026
lognaturel
left a comment
lognaturel
left a comment
Member
There was a problem hiding this comment.
Thank you!
Agreed uploading the artifact manually is ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
Checked actions run on my fork (run here) and it looks like the below screenshot - here the jar uses the last commit hash but for releases it uses the last tag:
Why is this the best possible solution? Were any other approaches considered?
Considered adding a release workflow, to automatically attach the jar to a tagged release. But it seems like at the moment, that requires creating a GitHub personal access token or changing permissions on the org token (or creating a GitHub app) etc - in any case it's an extra thing to manage vs. the manual method done about once a year (download built artifact, upload to release page). So, it's possible but I wasn't sure enough that it was worth it.
Are there any risks to merging this code? If so, what are they?
Unlikely to ever be a problem but when
archive: falseonly one file is allowed so if the build emits more than one jar it wouldn't work.