Skip to content

fix: post-merge correctness + hang fixes - #4

Merged
BlueBirdBack merged 1 commit into
mainfrom
devin/post-merge-fixes
Oct 11, 2026
Merged

BlueBirdBack merged 1 commit into
mainfrom
devin/post-merge-fixes

Conversation

@BlueBirdBack

Copy link
Copy Markdown
Contributor

Four small fixes found in post-merge review:

  • abs.sh:1849 — 'Disk random write 4K QD1' displayed read-side p95 (wrote 'p95 FAILED ms' on pure-write jobs). Use write_p95_ms.
  • run_iperf_cmd — watchdog was hardcoded to 18s, so IPERF_TIME>~13s was always killed mid-test and reported FAILED. Budget now follows IPERF_TIME + slack, capped at ABS_CMD_TIMEOUT.
  • abs_timeout — single SIGTERM could hang the whole script forever if the child ignored TERM (e.g. uninterruptible I/O). Escalates to SIGKILL after a 3s grace.
  • dd_fallback — wrote a fixed 256 MiB file with no space check; on a nearly-full fs this could fill the disk. Skips when <384 MiB free.

…LL-escalate abs_timeout, guard dd_fallback free space
@BlueBirdBack
BlueBirdBack merged commit 90f737d into main Oct 11, 2026
2 checks passed
@BlueBirdBack
BlueBirdBack deleted the devin/post-merge-fixes branch October 11, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant