fix: notify user when redocking a panel with no song loaded - #10
Merged
Conversation
_redockPanel() deleted the popups entry and bailed silently when currentFilename was empty, dropping the popped-out panel's state with no feedback — unlike the overflow-drop path a few lines down, which already toasts. Addresses a CodeRabbit review comment on upstream got-feedBack#23.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesRedock feedback
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_redockPanel() deleted the popups entry and bailed silently when
currentFilename was empty, dropping the popped-out panel's state with
no feedback — unlike the overflow-drop path a few lines down, which
already toasts. Addresses a CodeRabbit review comment on upstream
got-feedBack#23.