fix: color-key ordering, ordinal hover text, event-driven section refresh - #3
Open
carochacs wants to merge 1 commit into
Open
Conversation
…resh - SM_COLORS: check 'pre' before 'chorus'/'verse' so pre-chorus/pre-verse sections match their own color instead of the base section's (#1) - Keep the trailing ordinal digit in the hover title even though the on-bar label strips it, so repeated section names (Verse 1/2) are distinguishable on hover (#2) - Listen for the Host's song:ready event to build the bar immediately on load instead of waiting up to 200ms for the poller; the interval stays for continuous position/highlight/glass refresh, which needs to track the audio clock every tick (#3) - Add CLAUDE.md agent guide (got-feedBack#12) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
song:readyevent to build the bar immediately instead of waiting on the poller; documents why the interval itself can't go away (continuous position/glass refresh needs the audio clock every tick)Test plan
node --test tests/— 25/25 pass