[Question] Aggregate trait API #157

Activity

1. iitsdani commented on Sep 3, 2021

   

   iitsdani

   on Sep 3, 2021

   Collaborator

   More actions

   Hey there! Glad to have you here and please, ask all the questions you want! 😄

   Next time consider using the Github Discussion space rather than opening issues though 🙏🏻

   I'm curious about the Aggregate trait. In particular, the Aggregate::handle method returns a Result<Option<Vec<Self::Event>>. Is there a semantic difference in this return type between an Option::None and an empty Vec? If there is, where is it documented?

   No difference, when I wrote the API (too long ago) I was not aware that an empty Vec does not cause memory allocations 😄

   This change was supposed to be part of the v0.5.0 release 👍🏻
2. danieleades commented on Sep 3, 2021

   

   danieleades

   on Sep 3, 2021

   ContributorAuthor

   More actions

   Next time consider using the Github Discussion space rather than opening issues though

   totally. i thought that as soon as i created the two issues... you used to be able to convert issues to discussions. did that feature get pulled, or do you need to be a repo owner to see the option?
3. get-eventually

   locked and limited conversation to collaborators on Sep 3, 2021
4. iitsdani

   closed this as completedon Sep 3, 2021