Add Threads settings and standardize visual bells - #2597
Open
brsbl wants to merge 6 commits into
Open
Conversation
…fecycle-prototype-thr_q34zuky3js
…fecycle-prototype-thr_q34zuky3js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Thread-specific preferences were mixed into General settings, and archived conversations had no user-controlled retention policy. Visual bells also lacked one consistent layout for wrapping, actions, loading state, and dismissal.
What changed
Archived conversations:Keep forever(default) orDelete after 30 days.bb settings threads), and discoverable settings documentation.Thread Archivedtitle row followed by the clickable, non-underlined thread name and Undo on one row.This layer owns the Threads settings, archived-conversation retention, and visual-bell changes. It does not implement thread-storage, linked-worktree, or managed-environment cleanup; those changes remain isolated in the child PR.
The actionable archive bell keeps the existing 10-second duration.
Before and after
Settings before — PR merge base at
2d7850c030b5dffb428d2fa498ea1b94bb34c886The
/settings/threadsroute fell back to General, where the thread controls were mixed with app-wide settings.Settings after — PR head at
c69ea7f561a9e407c6950bdb1aef51129a677632Both Settings images use the exact compared revisions, the same fresh dev fixture and
/settings/threadsroute, Chrome for Testing 151.0.7922.71, and a 1440×900 viewport.Archived-thread bell before — PR merge base at
2d7850c030b5dffb428d2fa498ea1b94bb34c886Archived-thread bell after — PR head at
c69ea7f561a9e407c6950bdb1aef51129a677632Both bell images use the exact compared revisions and the same Toast Catalog fixture in Chrome for Testing 151.0.7922.71 at a 1440×900 viewport.
How you verified
c69ea7f561a9e407c6950bdb1aef51129a677632./settings/threadswithout runtime errors.git diff --checkpassed for the final layer diff.BB-Thread-ID: thr_q34zuky3js