Fix right-panel split removal and drop bounds - #2486
Merged
Conversation
brsbl
force-pushed
the
bb/fix-split-tab-ux-thr_q8degf2y66
branch
from
August 27, 2026 20:54
95875b8 to
35050ed
Compare
SawyerHood
force-pushed
the
bb/fix-split-tab-ux-thr_q8degf2y66
branch
3 times, most recently
from
August 27, 2026 22:51
75f988f to
35050ed
Compare
brsbl
force-pushed
the
bb/fix-split-tab-ux-thr_q8degf2y66
branch
from
August 27, 2026 23:47
35050ed to
e8f82c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove split× only while a right-panel tab is in a split.Product decision
Info and Diff remain fixed. Making them closeable would change existing Cmd+W, Cmd+D, mobile, and persisted-layout behavior. This layer extends the existing thread/page split semantics instead: closing a tab and removing a split remain two distinct actions.
Screenshot evidence
All web captures use Chrome for Testing 151.0.7922.71 at the same 1440×900 CSS viewport (DPR 2) and the same one-file
Split tab UX verificationfixture. The before revision is the PR merge baseb629714e31487bde8af5574639422a9b5c97cbb5; the after revision is exact PR head35050edb632c1007f14978c6c5e5bfe4dd83a259.Split-only remove control
Before, fixed Info and Diff panes have no remove-split affordance.
After, each split pane has a trailing ×. Its accessible name is
Remove split; it disappears when the layout returns to one pane.Drag boundary
Before, dragging a right-panel tab over the main workspace exposes the web-only
Group tab heretarget.After, the same drag over the main workspace has no drop target.
The right panel still exposes its intended split target.
Validation
Remove splitcontrols after the change, no main-workspace overlay after the change, and a preservedSplit bottomtarget inside the right panel.Closes #2450
BB-Thread-ID: thr_q8degf2y66