Surface collapsed child thread errors - #2383
Open
brsbl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Collapsed hierarchy rows derive their status from
getCollapsedChildActivity, but parented threads are deliberately excluded from the ordinary unread-completion model. That policy correctly kept successful child completions quiet, but it also discarded a terminal child failure, leaving the parent unmarked while the errored child row was hidden.What changed
errorstatus into the collapsed hierarchy's existingunreadErrorsignal and destructiveCircleXtreatment.ProjectRowregressions for collapsed errored and healthy direct children.How you verified
unreadErrorwasfalse) and passed afterward.pnpm exec turbo run test --filter=@bb/client-core --force -- test/thread-activity.test.ts— 39 passed.pnpm exec turbo run test --filter=@bb/app --force -- src/components/sidebar/ProjectRow.interactions.test.tsx— 11 passed.pnpm exec turbo run typecheck --filter=@bb/client-core --filter=@bb/app --force— passed.b6b43dcc4357e2d34c62bab9a652a27af0bc33a5in Chrome for Testing 151 across 390×844, 768×900, 1440×900, and 3440×1440. Each viewport passed five expand/collapse cycles, responsive transition widths, client navigation, and hard reload with zero page errors.Before — merge base
42d2c1becThe errored direct child is hidden, but its collapsed parent has no failure indicator.
After — PR head
b6b43dcc4The same fixture, route, interaction state, and viewport now show the existing failure indicator on the collapsed parent.
Fixes # — no linked issue.
BB-Thread-ID: thr_764udexes3