Skip to content

Add edge date range filtering - #337

Open
grogs84 wants to merge 3 commits into
gephi:mainfrom
grogs84:feature/edge-date-filtering
Open

grogs84 wants to merge 3 commits into
gephi:mainfrom
grogs84:feature/edge-date-filtering

Conversation

@grogs84

@grogs84 grogs84 commented Aug 31, 2026

Copy link
Copy Markdown

Summary

  • add inclusive date and datetime range filtering for edge attributes
  • make date range controls use observed dates and handle missing or invalid values
  • add an Edge dates demo dataset to the welcome menu
  • add import, serialization, unit, and end-to-end coverage

Testing

  • npm test (166 tests passed)
  • npm run test:e2e --workspace=@gephi/gephi-lite (5 tests passed)
  • npm run lint
  • npm run i18n-checker --workspace=@gephi/gephi-lite
  • npm run build

@sim51

sim51 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Hi,

Thanks for your PR.
Inside I see some good refacto, but I don't really see what you want to achieve with it.
It's already possible to add an edge filter on a date field. The only diff I see are :

  • displayed of the lower and upper bound on the bar chart, but we don't do it also on numeric. SO there is generic design question here
  • steps on the selection are not the same

Can you give me some insights on your PR ?

Comment thread README.md

You can read more about the intent of this project on the [Gephi blog](https://gephi.wordpress.com/2022/11/15/gephi-lite/).

## Filtering edges by date

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme file is not the project documentation, it should stay as simple as possible.
So this section should not be added here. If you want you can contribute on https://github.com/gephi/gephi-documentation

@@ -1,5 +1,7 @@
import { defineConfig, devices } from "@playwright/test";

const E2E_BASE_URL = "http://127.0.0.1:4173/gephi-lite/";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.

instances: [
{
browser: "chromium",
launch: process.env.PLAYWRIGHT_EXECUTABLE_PATH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.

instances: [
{
browser: "chromium",
launch: process.env.PLAYWRIGHT_EXECUTABLE_PATH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.

"serve": "vite preview",
"test": "vitest run src",
"test:e2e": "playwright test",
"test:e2e": "vite build && playwright test",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.

import { OpenModal } from "./open/OpenModal";

const SAMPLES = ["Les Miserables.json", "Java.gexf", "Power Grid.gexf"];
const SAMPLES = ["Les Miserables.json", "Java.gexf", "Power Grid.gexf", "edge-dates.gexf"];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to have one example per use-case., we want to keep those example as tiny as possible.
Please remove the "edge-dates.gexf" sample

Comment on lines -17 to -114
@@ -111,25 +111,25 @@
<br />
<h3 className="gl-px-2 gl-heading-3">{t("welcome.samples")}</h3>
<ul className="list-unstyled mb-0 d-flex flex-column">
{SAMPLES.map((sample) => (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you changed the var name sample to filename ?

@jacomyal
jacomyal requested a review from a team as a code owner October 7, 2026 09:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants