Repository navigation
Conversation
|
Hi, Thanks for your PR.
Can you give me some insights on your PR ? |
|
|
||
| You can read more about the intent of this project on the [Gephi blog](https://gephi.wordpress.com/2022/11/15/gephi-lite/). | ||
|
|
||
| ## Filtering edges by date |
There was a problem hiding this comment.
The readme file is not the project documentation, it should stay as simple as possible.
So this section should not be added here. If you want you can contribute on https://github.com/gephi/gephi-documentation
| @@ -1,5 +1,7 @@ | |||
| import { defineConfig, devices } from "@playwright/test"; | |||
|
|
|||
| const E2E_BASE_URL = "http://127.0.0.1:4173/gephi-lite/"; | |||
There was a problem hiding this comment.
You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.
| instances: [ | ||
| { | ||
| browser: "chromium", | ||
| launch: process.env.PLAYWRIGHT_EXECUTABLE_PATH |
There was a problem hiding this comment.
You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.
| instances: [ | ||
| { | ||
| browser: "chromium", | ||
| launch: process.env.PLAYWRIGHT_EXECUTABLE_PATH |
There was a problem hiding this comment.
You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.
| "serve": "vite preview", | ||
| "test": "vitest run src", | ||
| "test:e2e": "playwright test", | ||
| "test:e2e": "vite build && playwright test", |
There was a problem hiding this comment.
You should not modify this file in a feature PR.
If there is an issue with it, please describe it and create a separate PR.
| import { OpenModal } from "./open/OpenModal"; | ||
|
|
||
| const SAMPLES = ["Les Miserables.json", "Java.gexf", "Power Grid.gexf"]; | ||
| const SAMPLES = ["Les Miserables.json", "Java.gexf", "Power Grid.gexf", "edge-dates.gexf"]; |
There was a problem hiding this comment.
We don't want to have one example per use-case., we want to keep those example as tiny as possible.
Please remove the "edge-dates.gexf" sample
| @@ -111,25 +111,25 @@ | |||
| <br /> | |||
| <h3 className="gl-px-2 gl-heading-3">{t("welcome.samples")}</h3> | |||
| <ul className="list-unstyled mb-0 d-flex flex-column"> | |||
| {SAMPLES.map((sample) => ( | |||
There was a problem hiding this comment.
Why did you changed the var name sample to filename ?
Summary
Testing