Repository navigation
Deduplicate concurrent rrweb uploads - #1347
Open
vladislav805 wants to merge 2 commits into
Open
vladislav805 wants to merge 2 commits into
vladislav805 wants to merge 2 commits into
Conversation
sipayRT
reviewed
Oct 20, 2026
sipayRT
left a comment
Member
There was a problem hiding this comment.
One remaining deduplication edge case involving delayed probe responses:
commit: |
vladislav805
force-pushed
the
fix/dedupe-rrweb-installation
branch
from
October 21, 2026 09:51
4b68b12 to
2580464
Compare
Author
|
@sipayRT, fixed in 4b68b12. We now track completed uploads as well as in-flight ones. If a missing response predates a completed upload, the caller probes again without sending the library. If that fresh probe still reports missing, a new upload is allowed. Added regression tests for delayed responses, navigation, unsupported installation, and cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After navigation, concurrent DOM snapshot collectors can each detect missing rrweb and upload the entire library to the same browser session.
Share one in-flight upload per session while keeping event collection independent for each caller. Already-installed rrweb collections remain concurrent.
Invalidate pending collectors when cleanup starts. Discard late events to prevent mixing snapshots between retries, and preserve newer installation state when older operations finish.
Repeated navigation is handled with a bounded retry loop. Add debug logs for uploads, waits and discarded events.