Local docker run by sonic16x · Pull Request #1338 · gemini-testing/testplane

sonic16x · 2026-09-30T17:04:07Z

No description provided.

pkg-pr-new · 2026-10-01T03:20:15Z

npm i https://pkg.pr.new/gemini-testing/testplane@1338

commit: ab96268

github-actions · 2026-10-01T03:20:23Z

✅ Testplane browser-env run succeed

Report

github-actions · 2026-10-01T03:20:24Z

✅ Testplane E2E run succeed

Report

DudaGod

Я посмотрел локальный запуск браузеров в Docker. Ниже построчные замечания по совместимости образов, сети, безопасности и удобству запуска.

DudaGod · 2026-10-12T07:13:49Z

+        this._sessionIdForLogs = session.sessionId;
+        this._wdProcess?.setSessionId?.(session.sessionId);
+        const debuggerAddress = session.capabilities["goog:chromeOptions"]?.debuggerAddress;
+        if (debuggerAddress && !("browserWSEndpoint" in this._config && this._config.browserWSEndpoint)) {


Я бы не делал подготовку CDP обязательной при создании WebDriver-сессии. Пользовательский Chrome-образ может вернуть debuggerAddress, но не иметь devtools-адаптера, которого ожидает prepareCdp(). Тогда даже тест, использующий только WebDriver, не стартует. Можно ли инициализировать CDP только при первом обращении к нему?

Поправил

DudaGod · 2026-10-12T07:13:49Z

+import { prepareDockerBrowserImage } from "./docker-image";
+import { timeDockerOperation } from "./docker-timing";
+
+const PLATFORM = "linux/amd64";


Здесь жёстко задан linux/amd64, поэтому на Apple Silicon нативный arm64-образ будет отвергнут, а multi-platform образ запустится через эмуляцию. Я бы выбирал архитектуру текущего Docker-движка, сохранив возможность явно запросить другую платформу.

добавил возможность указывать параметром, но по дефолту такой

DudaGod · 2026-10-12T07:13:49Z

+        await writeFile(configPath, JSON.stringify(browsers));
+        // Set before creation to also clean up when the CLI times out after creating the network.
+        networkCreated = true;
+        await timeDockerOperation(name, "create network", () => docker(["network", "create", network]));


Я бы проверил IPv6 именно в создаваемой здесь сети. Включённый IPv6 у стандартного bridge не означает, что новая пользовательская сеть тоже получит IPv6. Сейчас браузерный контейнер может не открыть IPv6-only сайт, хотя сама VM имеет к нему доступ.

Добавил --ipv6 флаг

DudaGod · 2026-10-12T07:13:49Z

+                network,
+                // This is the socket path on the daemon's Linux host, including Docker Desktop/Colima.
+                "--volume",
+                "/var/run/docker.sock:/var/run/docker.sock",


/var/run/docker.sock — путь на стороне Docker-демона, а не сокет из выбранного локального Docker context. У rootless Podman он обычно находится в другом месте, поэтому описанный в документации сценарий может не запустить Selenoid. Я бы добавил настройку способа подключения контроллера к движку и проверку этого сценария.

по умолчанию такой, но добавил возможность менять через параметр

DudaGod · 2026-10-12T07:13:49Z

+                ...controllerSecurityArgs,
+                selenoidImage,
+                "-conf",
+                "/browsers.json",


Я бы передавал Selenoid -disable-privileged по умолчанию. Без этого флага он запускает браузерные контейнеры в privileged-режиме, а здесь пользователь может указать произвольный образ. Если отдельным образам нужны дополнительные привилегии, лучше включать их явно.

Добавил

DudaGod · 2026-10-12T07:13:49Z

+    }
+
+    const { selenoidImage } = config || {};
+    if (typeof selenoidImage !== "string" || !selenoidImage.trim()) {


Я бы не требовал от пользователя выбирать selenoidImage для базового сценария. Его цель — указать свой совместимый браузерный образ и запустить тесты; образ контроллера выглядит внутренней деталью Testplane. Можно ли дать публичный закреплённый default и оставить это поле для переопределения?

пока так, мы пока не запушили публичный образ селеноида

DudaGod · 2026-10-12T07:13:49Z

+    const manager = runs.get(owner);
+    if (manager) return manager.acquire(browserId, config, options, closeBrowser);
+
+    await standaloneStopping;


Если state.manager.stop() отклонится, standaloneStopping навсегда останется отклонённым Promise. После временного сбоя Docker любой следующий standalone-запуск упадёт на этом await. Я бы очищал состояние после ошибки и добавил тест на повторный запуск.

Поправил

DudaGod · 2026-10-12T07:13:49Z

+
+    it("should route Firefox sessions through /wd/hub inside the browser container", async () => {
+        const driver = await start(
+            "registry.yandex.net/selenium/firefox:148.0",


Я бы заменил адрес внутреннего registry в публичном тесте на нейтральный фикстурный адрес. Для проверки маршрута /wd/hub конкретный реестр не нужен.

поправил

shadowusr · 2026-10-14T22:16:04Z

This is a wrong place to add docs. I think we'll remove the docs/ directory in the near future. Docs should live on testplane.io and we've put a lot of effort into this migration.

shadowusr · 2026-10-14T23:15:09Z

            ...desiredCapabilities,
        },
        gridUrl: options.gridUrl || LOCAL_GRID_URL,
+        docker: options.docker,


I would think once again about the "docker" naming. Are we sure in this one?

For example, let's imagine that we'll need to support podman (a very real possibility). What will we do in that case? Add another podman field that would duplicate all the logic?

Perhaps it's not a problem. But I would seriously consider this possibility & make sure this design is future-proof in this sense.

keep docker, because it is obvious name

…browsers in containers

shadowusr · 2026-11-02T23:02:56Z

@codex review

chatgpt-codex-connector · 2026-11-02T23:03:10Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-02T23:21:29.459826Z	`ab96268`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97832f8f38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab96268ac9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-02T23:21:26Z

+            this._sampleState(queued.browserConfig.id);

-            this._newBrowser(queued.id, queued.opts).then(queued.resolve, queued.reject);
+            this._newBrowser(queued.browserConfig, queued.opts).then(queued.resolve, queued.reject);


Restore the queued request's test context before launching

When a browser request is queued behind a pool limit, _launchNextBrowser() runs inside the context of the test releasing the previous browser, rather than the queued test's context. Since request headers now come from getTestContext(), the queued test's session creation and SESSION_START requests receive the previous test's X-Request-ID prefix and traceparent. This incorrectly associates those requests with another test's diagnostics. Reproducing with a one-slot LimitedPool and contexts A and B yields A for both underlying launches. Capture the context when enqueueing and restore it when executing the queued launch.

Useful? React with 👍 / 👎.

sonic16x force-pushed the local-docker-run branch 2 times, most recently from 31261e5 to 4b60012 Compare October 1, 2026 03:17

sonic16x force-pushed the local-docker-run branch 3 times, most recently from d364192 to 98520eb Compare October 1, 2026 05:19

sonic16x force-pushed the local-docker-run branch from b7b963c to 84dc6a5 Compare October 8, 2026 07:05

DudaGod reviewed Oct 12, 2026

View reviewed changes

shadowusr reviewed Oct 14, 2026

View reviewed changes

sonic16x force-pushed the local-docker-run branch from 637ad86 to 6f435c3 Compare October 20, 2026 06:55

rocketraccoon and others added 17 commits October 29, 2026 14:10

feat: local docker browsers run

c4a3382

feat: add cpu limit check

8eda784

feat: add build docker with devtools fix

3cf56d1

feat: add docker prepare command

74d3a79

fix: fix podman + add docs

bd8dc83

fix: one selenoid for all browsers

604c66d

fix: move docker logs to debug section

23983a9

fix: logs

83bf32e

fix: support Docker browser images without CDP adapter

e884b47

fix: error freeze

bfd2c72

fix: pr fixes

da3ca49

fix: tests

23dc9a2

fix: cdp fix only for mac

bbf1918

fix: try to use dual-stack network with ipv6 support if possible for …

72e6b3a

…browsers in containers

fix: fix networking for rootless podman case in CI

4531ab5

chore: upgrade prettier for explicit resource management

37a435e

refactor(browser): centralize backend ownership and session cleanup

97832f8

shadowusr force-pushed the local-docker-run branch from c922623 to 97832f8 Compare November 2, 2026 23:02

chatgpt-codex-connector Bot reviewed Nov 2, 2026

View reviewed changes

Comment thread src/runner/index.ts Resolved

Comment thread src/browser-backend/docker/index.ts Resolved

fix(browser): preserve retained sessions and expose Docker CDP endpoint

ab96268

chatgpt-codex-connector Bot reviewed Nov 2, 2026

View reviewed changes

Conversation

sonic16x commented Sep 30, 2026

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Testplane browser-env run succeedReport

Uh oh!

github-actions Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Testplane E2E run succeedReport

Uh oh!

DudaGod left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonic16x Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shadowusr commented Nov 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026 •

edited

Loading

github-actions Bot commented Oct 1, 2026 •

edited

Loading

✅ Testplane browser-env run succeed

Report

github-actions Bot commented Oct 1, 2026 •

edited

Loading

✅ Testplane E2E run succeed

Report

sonic16x Oct 20, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 2, 2026 •

edited

Loading