Skip to content

CreateMachine flow to have separate steps to Create and Initialize Machine #1132

Description

@r4mek

How to categorize this issue?

/area robustness
/kind enhancement
/priority 3

What would you like to be added:
CreateMachine() to have separate steps, where in one step we will call the actual CreateMachine() function to create the VM on cloudprovider and the other to IntializeMachine() where initialization of VM can be done.

Why is this needed:
By having separate steps, we can keep retrying initialization without relying on the GetMachineStatusResponse which does static checks to identify whether initialization is done or not and is provider dependent. If the number of operations for initialization increase, we would have to check each of those to identify whether initialization is complete or not.

This is also needed if for openstack we decide to take some code out of existing CreateMachine into InitializeMachine where CreateMachine is only responsible for creating the Server on cloudprovider and InitializeMachine will patch the ports, extract InternalIPs, etc. then we have an easy deterministic way to identify whether initialization is done or not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/robustnessRobustness, reliability, resilience relatedkind/enhancementEnhancement, improvement, extensionpriority/3Priority (lower number equals higher priority)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions