Support shoots with disabled sshAccess

[MichaelEischer]

How to categorize this PR?

/area compliance
/kind bug
/platform openstack

What this PR does / why we need it:

Gardener supports disabling sshAccess for nodes. This results in Gardener deleting the ssh keypair. As a consequence the gardener-extension-provider-... and machine-controller-controller-provider-... need to work even if no keypair is present.

However, currently not setting the keypair for the mcm results in a KeyName is required error. Drop the validation as OpenStack does not actually require a keypair to be specified when creating a machine. The keypairs.CreateOptsExt{} struct from gophercloud already omits the keypair when an empty name is specified, such that no further changes beyond dropping the validation are necessary for this to work.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

gardener/gardener-extension-provider-openstack#1453 is the corresponding change for gardener-extension-provider-openstack to allow the overall feature to work.

Release note:

machine-controller-manager-provider-openstack supports creating machines without ssh key

[gardener-prow]

Welcome @MichaelEischer!

It looks like this is your first PR to gardener/machine-controller-manager-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if gardener/machine-controller-manager-provider-openstack has its own contribution guidelines.

Thank you, and welcome to Gardener. 😃

[federated-github-access]

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

[federated-github-access]

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

[federated-github-access]

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

[federated-github-access]

The PR needs to be labeled with ok-to-test by a maintainer to trigger the automated validation of the change

[MichaelEischer]

/cc @kon-angelo

Could you take a look at the PR?

[hebelsan]

/lgtm

[gardener-prow]

LGTM label has been added.

Details

Git tree hash: 3d4d856ae3df59420bd494a39aea55423103628e

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreasBurger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [AndreasBurger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MichaelEischer]

Thanks a lot. Do you have an idea when there will be a new release?

Would it be possible to also get #416 or #417 merged?

[AndreasBurger]

I'm working on getting PRs merged and a new release. I can't commit to any solid ETA, but I'm trying to get a MCM-OS and provider-OS release out as soon as possible.