Skip to content

Dsum - #93

Merged
cdwensley merged 2 commits into
gap-packages:masterfrom
cdwensley:dsum
Jul 31, 2026
Merged

Dsum#93
cdwensley merged 2 commits into
gap-packages:masterfrom
cdwensley:dsum

Conversation

@cdwensley

Copy link
Copy Markdown
Collaborator

The direct sum operations are not working correctly, so some tests commented out.
Several of the algebra mappings created appear not to be single-valued: not at all sure why!
So this is a very provisional PR added to make the tests pass.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.92%. Comparing base (927c05a) to head (9bc9896).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/dsum-xmod.gi 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   72.09%   66.92%   -5.17%     
==========================================
  Files          10       12       +2     
  Lines        2584     2912     +328     
==========================================
+ Hits         1863     1949      +86     
- Misses        721      963     +242     
Files with missing lines Coverage Δ
lib/dsum-xmod.gd 100.00% <ø> (ø)
lib/dsum-xmod.gi 22.15% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdwensley
cdwensley merged commit 1dafb2c into gap-packages:master Jul 31, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant