Download: tolerate a curlInterface that honours 'target' itself - #104
Open
fingolfin wants to merge 1 commit into
Open
Download: tolerate a curlInterface that honours 'target' itself#104fingolfin wants to merge 1 commit into
fingolfin wants to merge 1 commit into
Conversation
The 'via DownloadURL' method passes the whole option record to 'DownloadURL' and then writes 'res.result' to the target. curlInterface is gaining a 'target' option of its own (gap-packages/curlInterface#62), and then returns no 'result', so this errored with Record Element: '<rec>.result' must have an assigned value Guarding on 'result' being bound works with either version, and with the newer one the file is never held in memory as a whole. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 86.24% 86.25%
=======================================
Files 32 32
Lines 1905 1906 +1
=======================================
+ Hits 1643 1644 +1
Misses 262 262
🚀 New features to boost your workflow:
|
Contributor
|
Taking #103 into account: Up to now, the curlInterface based method never wrote a file, therefore one need not care about removing corrupted files after failures. Once curlInterface writes files, do we have to remove such files here or can we assume that curlInterface has already dealt with them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
via DownloadURLmethod passes the whole option record toDownloadURLand then writes
res.resultto the target itself. curlInterface is gaining atargetoption of its own (gap-packages/curlInterface#62) and then returns noresult, so this errors withGuarding on
resultbeing bound works with either version, and with the newerone the file is never held in memory as a whole.
Neither CI catches this:
utilsdoes not install curlInterface, andcurlInterface does not test
utils. Worth merging before curlInterface#62.Written with Claude Opus 5 via Claude Code; reviewed by me.
CC @ThomasBreuer