Do not print generators in a manual example - #100
Merged
Merged
Conversation
The example for UpperFittingSeries and LowerFittingSeries printed the results, which includes generating set chosen for some of the terms. But these can vary depending on the GAP version and which packages are loaded. Since we print the structure descriptions of these groups right afterwards anyway, it should be fine to just not print the terms of these series. See gap-system/gap#2434 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 86.24% 86.24%
=======================================
Files 32 32
Lines 1905 1905
=======================================
Hits 1643 1643
Misses 262 262 🚀 New features to boost your workflow:
|
Collaborator
|
Looks fine, but I will also adjust the D12 example and make the manual agree with the test file. |
cdwensley
added a commit
that referenced
this pull request
Aug 4, 2026
release 0.98 fixes issue #100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example for UpperFittingSeries and LowerFittingSeries printed
the results, which includes generating set chosen for some of the
terms. But these can vary depending on the GAP version and which
packages are loaded.
Since we print the structure descriptions of these groups right
afterwards anyway, it should be fine to just not print the terms
of these series.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 noreply@anthropic.com