Add recently-used file list to the welcome screen - #1119
Open
d-kad wants to merge 1 commit into
Open
Conversation
d-kad
force-pushed
the
welcome_screen
branch
from
September 4, 2026 13:53
26df747 to
4d429d4
Compare
tturocy
requested changes
Sep 7, 2026
| constexpr int ID_WELCOME_RECENT_LAST = ID_WELCOME_RECENT_FIRST + MAX_RECENT_FILES - 1; | ||
|
|
||
| /// Drop `p_filename` from the application's most-recently-used list, if it is there. | ||
| void RemoveFromFileHistory(const wxString &p_filename) |
Member
There was a problem hiding this comment.
This (and some of the other bits below) are independently managing the MRU file list, separate from the mechanism that's already present in the App class. We should consolidate all the data-model manipulation as part of the App - and focus this file on the UI itself.
| content->Add(m_newExtensiveFormButton, 0, wxEXPAND, 0); | ||
|
|
||
| // Hidden, and contributing no height, when there is no file history to show. | ||
| content->Add(m_recentLine, 0, wxEXPAND | wxTOP | wxBOTTOM, 20); |
Member
There was a problem hiding this comment.
I don't think the MRU file list is in the right place logically - it should be linked visually to the Open option. I've had the attached mockup done for a combo-button-dropdown type approach which seems a bit more elegant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Description of the changes in this PR
This PR adds a list of recently opened games to the welcome screen, below the existing buttons.