feat(queen): the review valve -- no person in the loop (Closes #6616) - #6617
Merged
Merged
Conversation
…step and a clock (Closes #6616) specs/queen/review_valve.t27 is the one home of the owner's rule of 2026-10-05 ("no person is needed"): escalations release as failed after a floor (30 min; 60 min for a spent send-back ceiling), at most MAX_RELEASES=1 per issue, then close as obsolete with the reason recorded and the boundary freed; missing or unrunnable criteria wait at most 120 min for a backfill; a reviewer-bee REQUEST_CHANGES on a queen-* PR goes back to the Queen at most PR_FIX_ATTEMPTS=2 times, then the PR closes (48 h without a push). gen/c/queen/review_valve.c is t27c gen-c output: 8 tests pass with -DT27_TEST_MAIN, a mutant that never releases fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 5, 2026
Merged
Contributor
This was referenced Oct 5, 2026
Contributor
PR DashboardGenerated at: 2026-10-05 21:45:41 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6616
What
specs/queen/review_valve.t27is the one home of the owner's rule of 2026-10-05: no person is needed in the review loop. Every review outcome that is not an accept gets an automatic next step and a clock:failed(retry)RETRY_FLOOR_MINUTES)CEILING_FLOOR_MINUTES)BACKFILL_WINDOW_MINUTES)MAX_RELEASES= 1)obsolete, reason recorded, boundary freedqueen-*PRPR_FIX_ATTEMPTS= 2, then the PR is closed (also after 48 h with no push)The test
no_kind_waits_for_a_personchecks that, at the policy's own 48-hour hold, no kind of escalation still holds its files.Why these numbers
Measured 2026-10-05: 144 of 219 review cards were escalated. Of the 193 stuck branches, 125 were empty. fileConflict was 108, and 25 of 70 workers were active. The constants reuse the supervisor's measured floors (
EMPTY_ATTEMPT_FLOOR_MS,CEILING_RELEASE_MS,maximumSendBacks). There is one release per issue because 65% of the stuck branches are empty after three silent attempts each. The reasoning for each constant is in its doc comment.Files
specs/queen/review_valve.t27: the spec, with 8 tests and 1 invariantgen/c/queen/review_valve.c:t27c gen-coutput.cc -DT27_TEST_MAINgivesAll 8 tests passed., and a mutant that never releases failstest_an_empty_attempt_is_released_after_the_floordocs/now/2026-10-06-queen-review-valve.mdNot here: the gHashTag/BrowserOS wiring (a separate PR; the owner merges it). The
tools/bees/reviewer.pyandcriteria_backfill.pychanges are described in #6616 and not written.🤖 Generated with Claude Code