feat(t27b): lower the multi-object for loop - #6575
Merged
Merged
Conversation
…lti-2 # Conflicts: # cli/t27b/src/lower.rs
gHashTag
added
the
owner-approved-foreign
Contributor
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6458
Refs #6063
What
for (a, b) |x, y|(a multi-object for over arrays and slices) lowers as one loop over the shared length, with one capture per object.TrapKind::ForLength = 17("for loop over objects with non-equal lengths").for_iterable, thenfor_objects.cli/t27b/src/lower/formulti.rs;lower.rskeeps the hook, andir.rsgains the trap kind.Owner exception
Allowed by the owner 2026-10-05; debt to be replaced via #6198.
The local only-t27 hook (#6511) read an uncommitted line in
tools/policy/foreign-exceptions.txtthat names this PR's paths. That line is not in this PR, so the exception ends with the PR.Files
cli/t27b/src/ir.rs(trap kind)cli/t27b/src/lower.rs(hook and extracted helper)cli/t27b/src/lower/formulti.rscli/t27b/tests/formulti.rscli/t27b/tests/source.rs(dropped the multi-object refusal case)docs/now/2026-10-05-t27b-formulti.mdTests
cargo test -p t27b: all green.tests/formulti.rshas 3 tests: equal lengths pass, a run-time mismatch traps, and a comptime mismatch is refused. Each source was run undert27c test-reportfirst.Corpus (
t27b corpus specs --blockers --reference <t27c> --reference-cache, jobs 8)No file changes verdict on its own. The two files this blocked still have another blocker each:
gen_cross_entropyneeds@log.gen_linear_regressionneeds&[_]f64{ ... }locals; those come in the next PR, which unlocks it.🤖 Generated with Claude Code