Repository navigation
fix(t27b): signal a timed-out group with kill(2), not procps kill - #6362
Merged
Merged
Conversation
procps-ng 4.0.2 (the lab's Debian bookworm image) reads `kill -KILL -<pgid>` as `kill -KILL -1`, so every corpus timeout on the lab killed every process but PID 1, the corpus driver included (lab runs d8375ad and 84e478b: exit -9, no JSON). Call kill(2) with a negative pid directly and refuse pgid 0 and 1. Closes #6361 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Owner
Author
|
Lab check of this branch (8258b73), cross-built on the t27b lab container in a separate target dir. The run used qemu-aarch64 with
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6361 (Refs #6063)
What
run_capture(cli/t27b/src/blockers.rs) signals a timed-out child's process group withkill(2)directly. Before, it spawnedkill -KILL -<pgid>. It also refuses pgid 0 and 1.Why
The lab image ships
kill from procps-ng 4.0.2, which reads a negative pid that follows a signal as -1. I checked this on the lab container:/bin/kill -CONT -999999gives rc 0, although no such group exists./bin/kill -CONT -- -999999gives rc 1,No such process.So the first 60 s corpus timeout on the lab sent SIGKILL to every process except PID 1, including the corpus driver. That is why runs d8375ad and 84e478b show
t27b corpus exited -9 and wrote no JSONat about 62-68 s.Evidence (lab at 84e478b)
killwrapper that execs/bin/kill, the driver died right after-KILL -1165936.retrying 2 timed-out file(s).oom_kill 0, memory.peak 5.4 GB of 24 GB.Tests
a_timeout_kills_the_group_and_spares_the_caller. The group includes a grandchild holding the pipe, and the test asserts it dies.cargo test -p t27b --test blockers: 7 passed, run locally on macOS.🤖 Generated with Claude Code