Conversation
…dd the test.brain card gHashTag/trinity#1333 restores the brain test steps that trinity#517 had dropped from build.zig. The consumer cannot carry a card for them on its own: external/t27 is a byte-locked vendored copy of these cards, and the manifest check reads targets at the revision project.t27 pins. So the pin moves first, here, and the consumer re-vendors after this merges. - specs/trinity/project.t27: PINNED_REVISION 976df517 -> 291ac8b24 (head of trinity#1333). Counts re-measured by tools/trinity_manifest.py inventory on a full checkout: 2831 .zig (2076 unreachable), 79 tests, 71 steps, 40 canonical / 2291 mirror / 70 vendored .t27, catalog 1776 specs from 14 repositories. Executables 51, libraries 6, installs 46/3, registry 29, dependencies and T27_REVISION unchanged. - specs/trinity/capabilities/test.brain.t27 (new, S03): owns the five restored steps and test:src/brain/*; measured by S3AI Brain CI run 37184075728 on push at 291ac8b24. - research.unreferenced-sources keeps src/brain: 37 of its files are still unreachable; the restored steps reach the other six. - The 50 card headers name the pin by reference to project.t27 instead of quoting 976df517. The 18 measured cards say their evidence is from 976df517 and was not measured again at the new pin. - conformance/trinity/{inventory,report}.json regenerated; README section for the new pin, the 976df517 bullets kept below it. - 52 seals re-saved with t27c seal --save; --verify gives MATCH for all. S03's build_graph.t27 and the other per-spec pins stay at 976df517. Refs #3563 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Oct 4, 2026
Owner
Author
|
Closed as superseded by #5965 (squash 39e06aa), which adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gHashTag/trinity#1333 restores the brain test steps that gHashTag/trinity#517 removed from
build.zig. Brain CI is green there, but the headless-profile job fails with 11UNASSIGNED_TARGETviolations because no card owns the new targets. The consumer cannot add that card itself.external/t27is a byte-locked copy of these cards, and the manifest check reads targets at the revisionproject.t27pins. So the pin moves here first, and the consumer re-vendors after this PR merges.This PR:
976df517to291ac8b24, the head of trinity#1333;specs/trinity/capabilities/test.brain.t27(S03).What changed
specs/trinity/project.t27PINNED_REVISIONmoves to291ac8b24308ee39703393b6ea5363c166079b79.Changed counts, re-measured by
tools/trinity_manifest.py inventoryon a full checkout:Unchanged: executables 51, libraries 6, installs 46 / 3 guarded, registry 29, dependencies,
T27_REVISION.test.brain.t27(new)step:test-basal-ganglia,step:test-reticular-formation,step:test-locus-coeruleus,step:test-brain,step:test-brain-stressandtest:src/brain/*.EVIDENCEismeasured, from S3AI Brain CI run 37184075728. That run was on push at291ac8b24exactly; all five steps exited 0 (51/51, 48/48, 52/52, 151/151, 261/261).research.unreferenced-sourcessrc/brain. The restored steps reach 6 of the 43 files ofsrc/brainthatbuild.zigdid not reach at976df517, and 37 stay unreachable.The 50 existing card headers
976df517.The 18
measuredcardsEVIDENCE_SOURCEnow says the measurement was taken at976df517and was not repeated at the new pin. See "Not measured".conformance/trinity/inventory.jsonandreport.jsonspecs/trinity/README.md291ac8b24pin. The976df517section is kept under it.Seals
project.t27, the 50 cards and the new card.Left unchanged
build_graph.t27and every other per-spec pin stay at976df517.queen_viewskeepsafc9d384.Measured locally
The clone was sparse:
specs/{api,brain,catalog,fpga,isa,numeric,queen,tools,trinity,ui,vsa},tools,.trinity/seals,conformance/trinity,docs/system,.github/workflows. The trinity tree was checked out in full at291ac8b24, with all 2831.zigfiles present.trinity_manifest.py checkOK -- 52 capabilities over gHashTag/trinity@291ac8b24, 51 executables / 6 libraries / 79 tests / 71 steps all ownedtest.brain.t27removedUNASSIGNED_TARGET(the same 11 the trinity#1333 job reports)test.graphalso ownsstep:test-brainDUPLICATE_TARGETtrinity_manifest.py --self-checkt27c seal --verify, 52 specscheck_seal_currency.pycheck_specs_still_parse.py --base origin/mastercheck_duplicate_declarations.pyNot measured
check_seal_coverage.pyandcheck_ring_spec_drift.pygave no usable result on the sparse clone.fb83b54b3.aca71b5re-sealed 10 specs that carry structs; none of them is in this PR.measuredcards were not re-measured at291ac8b24. Their evidence strings now say so, rather than claiming the measurement carried over.test.brain's singleACCEPTANCEcommand, with all five steps at once, was not run. Each step was run on its own in the cited run.291ac8b24reported onlyPIN_MISMATCH(edges 252 -> 255, package edges 152 -> 155).main.291ac8b24stays fetchable but is not inmain's history.After this merges, in gHashTag/trinity#1333
python3 tools/contracts.py vendorat the new t27 revision.trinity/test.braintoRUNorNOT_RUNinspecs/reproduce/capabilities.t27, since the card has anACCEPTANCE.Opened as a draft. Merging is the owner's decision.
Refs #3563
🤖 Generated with Claude Code