specs/numeric: GF8/20/24/32 invariants check concrete points instead of prose the parser drops - #5699
Closed
dmitrii-f-t27 wants to merge 1 commit into
Closed
dmitrii-f-t27 wants to merge 1 commit into
dmitrii-f-t27 wants to merge 1 commit into
Conversation
…of prose the parser drops (#5698)
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5698
t27c parse-completedropped 37 tokens from gf8 and 31 each from gf20, gf24 and gf32. These were prose invariants (for all positive x,for all valid x,floor(x) == i32 for all f32 x, and in gf8PHI_DISTANCE == 0.132 within 0.001). Each invariant kept its name and lost its body, so nothing was checked.floor(floor(x)) == floor(x). The gf8 phi distance usesabs(...) < 0.001.parse-complete --shownow printsnothing discardedfor all four specs.ast-checkgives 3 errors on master and 3 on this branch: the same pre-existingunused capture, which also blockstest-reporton master.--verifyreports all hashes MATCH.🤖 Generated with Claude Code