fix(ports): redo the fifteen non-generating ports in the supported subset - #5617
Merged
Merged
Conversation
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
Contributor
PR DashboardGenerated at: 2026-10-02 18:47:47 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5549
The fifteen port specs under specs/port/ that fail to parse on master are redone against their originals in the supported subset, following the sibling-port idiom: pure logic is kept (the GF-T sadd/smul/magmul family in gft_generalize_demo, the FP64 decode in gf_decode_param_fp64, the receipt verdict rules in trinity_fpga_adapter, the VSA bind/bundle/cosine in vsa), and host actions (file I/O, subprocesses, GitHub API, rng training demos) are honest stubs — exactly how the generating sibling ports in specs/port/tools/ already behave.
Every one of the fifteen now passes
t27c typecheckand generates witht27c gen-candt27c gen. The fifteen lines are removed from tools/specs_generate_baseline.txt, so the gate can catch the next spec that stops generating.Refs #5497