Skip to content

Implement the 6 empty function bodies in specs/tri/trees/tree.t27 - #3872

Merged
gHashTag merged 2 commits into
masterfrom
queen-3819
Sep 17, 2026
Merged

gHashTag merged 2 commits into
masterfrom
queen-3819

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Work the Queen accepted on , closed as gHashTag/trios#3819, and never merged.\n\nMeasured 2026-09-04: 174 branches on the remote and FIVE contained in . The other 169 all carry a real diff. A closed issue whose code is not in the branch is a false statement about the repository, and the loop had been making 169 of them.\n\nMerges cleanly against the current base, checked with before this PR was opened.

Closes #3819

Trinity Bee added 2 commits September 15, 2026 17:10
- Update leaf function to return Tree(T) instead of void
- Update branch function to take left and right parameters and return Tree(T)
- Update is_leaf function to return bool instead of void
- Update height function to return usize instead of void
- Update size function to return usize instead of void
- Update inorder function to return []T instead of void
- Update branch test to use both left and right parameters

Closes #3819
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-16 15:04:27 UTC

Summary

Status Count
Total Open PRs 19
PRs with Failing Checks 17
PRs with All Checks Green 2
READY 2
FAILING 17
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=7cab95c431bc != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag

Copy link
Copy Markdown
Owner Author

The generated Zig does not compile

tri/trees/tree.zig: use of undeclared identifier 'max'

Measured by generating this spec with t27c gen into a tree mirroring specs/ and running zig test on it. The same spec on master compiles, so this branch introduces the failure.

Every stated acceptance criterion on this issue passes. That is the gap this check exists to close: until now nothing in the pipeline ever executed what a spec generates.

Reproduce: queen witness specs/tri/trees/tree.t27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the 6 empty function bodies in specs/tri/trees/tree.t27

1 participant