Skip to content

queen: harvest 9 bee patches that pass their own acceptance criteria (#3508 #3515 #3524 #3525 #3530 #3531 #3534 #3536 #3538) - #3560

Merged
gHashTag merged 11 commits into
masterfrom
queen/harvest-2026-09-10
Sep 10, 2026
Merged

queen: harvest 9 bee patches that pass their own acceptance criteria (#3508 #3515 #3524 #3525 #3530 #3531 #3534 #3536 #3538)#3560
gHashTag merged 11 commits into
masterfrom
queen/harvest-2026-09-10

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

What this is

The Queen swarm (trios-agent-server on Railway) worked issues #3507–#3542 on 2026-09-09/10 and committed its results to queen-<issue> branches inside the container volume. The bee contract says "do not push", so nothing ever reached GitHub. This PR harvests that work: railway ssh → git format-patch per branch → git am onto master (4a740c7b), authorship preserved (Trinity Bee <bee@trinity.local>).

Base the bees built on: b33485b5 (#3506). All 34 patches applied to master with no conflicts.

What got in — and what did not

The swarm's reviewer marked 26 of these as accepted. Re-running each issue's own acceptance criteria against the harvested file with ./target/release/t27c built from master gives a different picture:

  • 9 patches meet their issue's criteria and pass every repo gate → they are in this PR.
  • 20 patches do not parse (t27c parse hard error, e.g. then x == fn ([]i64) void in a test block). All 20 files parse clean on master.
  • 4 patches parse with DISCARD — the parser drops a test-block assertion (std.mem.eql(...), @FieldType(...), std.meta.fields(...)), so criterion 1c (parse clean) is unmet.
  • 1 patch (Implement the nine comment-only functions in specs/ml/transformer/mha_block.t27 (MHABlock) #3518) meets its issue's numbers but introduces a typecheck failure (forward expects 2 args, got 3) that trips the corpus ratchet, and adds 4 TODO: Implement dropout markers. Excluded.

INFERENCE: the in-container reviewer has no t27c (no cargo in the image), so it could not run criteria 1c/3/4/5 and accepted on the body scan alone. That is the "misleading green" this repo's gates exist to catch. Follow-up: give the review lane a t27c binary, or run the criteria from a GitHub Action on pushed queen/* branches.

Not included: uncommitted worktree changes for #3507 (bitvector.t27, 159 lines), #3514 (status.t27), #3521 (text.t27, 172 lines) — bees were still working; harvested as .dirty.diff but not applied.

Per-issue verdict (34 branches, 36 issues)

issue file swarm verdict re-check on master t27c
#3507 specs/tri/collections/bitvector.t27 wait no commit; 159-line uncommitted worktree diff
#3521 specs/tri/utils/text.t27 wait no commit; 172-line uncommitted worktree diff
#3508 specs/tri/utils/random.t27 accepted met — in this PR
#3509 specs/tri/utils/utf8.t27 wait parse error: parse error in fn 'encode' near line 110: unexpected toke
#3510 specs/tri/utils/version.t27 wait parse error: parse error in fn 'parse' near line 29: Unexpected token
#3511 specs/tri/net/net.t27 accepted parse error: parse error in fn 'parse_ip' near line 44: parse error ne
#3512 specs/tri/search/knuth_morris_pratt.t27 accepted parse error: parse error in fn 'build_prefix' near line 25: unexpected
#3513 specs/tri/collections/bitmap.t27 accepted parse error: parse error in fn 'init' near line 26: unexpected token a
#3514 specs/git/status.t27 wait unmet: tb 12/19 types 20/18
#3515 specs/tri/collections/ring_buffer.t27 accepted met — in this PR
#3516 specs/tri/crypto/base64.t27 accepted parse error: parse error in fn 'encode' near line 34: unexpected token
#3517 specs/tri/collections/deque.t27 wait parse error: parse error in fn 'push_front' near line 40: parse error
#3518 specs/ml/transformer/mha_block.t27 accepted typecheck regression (forward expects 2 args, got 3, lines 145/199); adds 4 TODO: Implement dropout
#3519 specs/tri/math/statistics.t27 wait parse error: parse error in fn 'median' near line 50: unexpected token
#3520 specs/tri/utils/bytes.t27 accepted parse error: parse error in fn 'split' near line 112: Unexpected token
#3522 specs/tri/utils/logging.t27 accepted parse DISCARD: a test-block assertion the parser drops
#3523 specs/tri/collections/option.t27 accepted parse error: parse error in fn 'none' near line 29: Unexpected token i
#3524 specs/ml/activation/relu_activation.t27 accepted met — in this PR
#3525 specs/tri/math/bezier.t27 wait met — in this PR
#3526 specs/tri/encoding/msgpack.t27 accepted parse error: parse error in fn 'encode' near line 38: Unexpected token
#3527 specs/tri/utils/config.t27 wait parse error: parse error in fn 'parse' near line 42: Expected LBrace,
#3528 specs/tri/collections/priority_queue.t27 accepted parse error: parse error in fn 'enqueue' near line 32: parse error nea
#3529 specs/tri/collections/circular_buffer.t27 accepted parse error: parse error in fn 'init' near line 28: unexpected token a
#3530 specs/ml/activation/gelu_activation.t27 accepted met — in this PR
#3531 specs/tri/collections/array.t27 accepted met — in this PR
#3532 specs/tri/io/filesystem.t27 accepted parse DISCARD: a test-block assertion the parser drops
#3533 specs/tri/math/polynomial.t27 wait parse error: parse error in fn 'add' near line 44: Unexpected token in
#3534 specs/tri/collections/linked_list.t27 accepted met — in this PR
#3535 specs/tri/graph/disjoint_set.t27 accepted parse DISCARD: a test-block assertion the parser drops
#3536 specs/tri/crypto/sha256.t27 accepted met — in this PR
#3537 specs/tri/crypto/hex.t27 accepted parse error: parse error in fn 'encode' near line 33: unexpected token
#3538 specs/tri/math/constants.t27 accepted met — in this PR
#3539 specs/ml/activation/sigmoid_activation.t27 accepted parse DISCARD: a test-block assertion the parser drops
#3540 specs/ml/activation/softmax.t27 accepted parse error: parse error in fn 'forward' near line 41: parse error nea
#3541 specs/tri/graph/graph_bfs.t27 accepted parse error: parse error in fn 'init' near line 31: unexpected token a
#3542 specs/tri/sort/quick_sort.t27 accepted parse error: Expected LBrace, got KwTest ('test') at line 76:5
"swarm verdict" is what /queen/status reported at 2026-09-10T01:2xZ (completed = accepted, claimed = review/wait).

Gates run locally on this branch (t27c from master + these commits)

gate result
t27c parse-complete --specs-dir specs 838 scanned / 693 consume-all / 0 TRUNCATE / 76 DISCARD (23831 tokens) / 69 no-parse — identical to master
t27c suite --repo-root . --ratchet --corpus-only RATCHET: CLEAN (0 unexpected failures, 0 discard worsened)
tools/published_figures.py --check exit 0 after moving 3 pins with the reason in the pin: test blocks 12465 → 12542 (+77, on top of #3556), x.len reads 680 → 710 (+30), []T{} literals 478 → 480 (+2)
tools/published_figures.py --self-check exit 0
tools/check_duplicate_declarations.py exit 0
tools/check_assertionless_spec_tests.py ok, baseline 4054/33 unchanged

No --bless; no ratchet raised. Per-branch check script and raw results: harvested locally (check.py, results.json) — happy to add them under tools/queen/ in a follow-up if wanted.

Closes #3508, closes #3515, closes #3524, closes #3525, closes #3530, closes #3531, closes #3534, closes #3536, closes #3538

Trinity Bee and others added 10 commits September 10, 2026 03:25
Trinity Bee gHashTag
Implement TriRandom Xorshift64* PRNG with all required functions and …
e35bce4 
…tests

- Implement init(), next(), range(), and range_inclusive() functions
- Add XORSHIFT_MULTIPLIER constant (2685821657736338717)
- Handle zero seed substitution with DEFAULT_SEED (88172645463325252)
- Add 4 new test blocks bringing total to 10
- Remove all TODO: Implement comments
- Follow Xorshift64* algorithm with correct shifts (12, 25, 27)

Refs #3560
Trinity Bee gHashTag
Implement TriRing ring buffer functions
22f7582 
- Replace all TODO implementations with real function bodies
- Implement new(), push(), pop(), is_empty(), is_full() with correct signatures
- Add comprehensive test blocks for each function (11 total test blocks)
- Maintain parse-clean status and preserve all existing tests
- Implement ring buffer logic with proper modulo arithmetic
- Handle full/empty states correctly (head == tail for empty, (tail + 1) % capacity == head for full)
- Ensure push stops at capacity - 1 usable entries as required

Refs #3560
Trinity Bee gHashTag
Implement ReLU activation functions with leaky support
b26264e 
- Implement forward(): max(0, x) with configurable negative_slope
- Implement backward(): sparse gradients using forward input as gate
- Add comprehensive test blocks covering identity, scaling, and zero cases
- Use ZERO constant consistently instead of literal 0.0
- Add note about inplace parameter being unused
- Maintain existing tests and invariants

Resolves #3524

Closes #3524
Trinity Bee gHashTag
Implement Bézier curve functions with de Casteljau algorithm and deri…
25f84f7 
…vative

- evaluate(): Implements de Casteljau's algorithm for stable curve evaluation
- derivative(): Returns the hodograph curve with scaled control point differences
- Added comprehensive test cases covering edge cases and basic functionality
- Maintains existing tests and adds new ones for t=0, t=1, and derivative behavior

Refs #3560
Trinity Bee gHashTag
Implement GELU activation functions with exact and approximate branches
dd1591b 
- Implement forward() function with both exact (erf) and approximate (tanh) forms
- Implement backward() function with derivatives for both forms
- Add comprehensive test coverage for both functions
- Use declared constants SQRT_2_OVER_PI and SQRT_PI_OVER_2
- Branch on config.approximate in both functions
- Ensure element-wise slice operations with proper bounds checking

Resolves #3530

Closes #3530
Trinity Bee gHashTag
Implement all functions in TriArray module
9882b42 
- Updated all 9 function signatures to match specification
- Implemented slice, slice_from, first, last, is_empty, contains, index_of, reverse, concat
- Added comprehensive test blocks for all functions (26 total test blocks)
- Removed all TODO: Implement comments
- Maintained zero-copy semantics and proper error handling

Refs #3560
Trinity Bee gHashTag
Implement linked list functions and tests
be051df 
- Implement init(), append(), prepend(), remove(), deinit() functions
- Replace 5 placeholder tests with 10 real tests
- Add comprehensive test coverage for boundary conditions
- Maintain all original function signatures
- Remove all TODO comments and default_input references

Refs #3560
Trinity Bee gHashTag
Implement SHA-256 module with full Merkle-Damgard construction
aab3f0c 
- Add H0 and K constants with correct FIPS 180-4 values
- Implement init(), update(), final(), and hash() functions
- Add compression function with all SHA-256 operations
- Add test blocks for all functions with FIPS vectors
- Fix function signatures to match specification
- Remove all TODO stubs

Acceptance criteria:
- 4 named functions exist with non-empty bodies: met
- 0 TODO markers: met
- Real-code node count >= 8: met
- 7 test blocks: met
- Round constant 0x428a2f98 present: met

Refs #3560
Trinity Bee gHashTag
Implement all 12 constant accessor functions with proper bodies and c…
413802c 
…omprehensive test coverage

- Implement 4 SystemLimits accessors with documented power-of-two values
- Implement 6 SacredConstants accessors with full-precision mathematical constants
- Implement 2 aggregate accessors that compose individual accessors
- Add 16 new test blocks covering all functions and their identities
- Remove all TODO: Implement comments
- Maintain parse-clean status and existing test blocks

Resolves #3538

Closes #3538
gHashTag
tools: move the published-figure pins with the queen harvest (+77 tes…
cf774b5 
…t blocks, +30 x.len reads, +2 empty slice literals)

Refs #3560
@gHashTag
gHashTag force-pushed the queen/harvest-2026-09-10 branch from 00034ab to d3b9e49 Compare September 10, 2026 03:28
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-10 03:28:45 UTC

Summary

Status Count
Total Open PRs 16
PRs with Failing Checks 13
PRs with All Checks Green 3
READY 2
FAILING 13
PENDING 0
NO CHECKS YET 0

These columns do not partition: 2 + 13 + 0 + 0 = 15, and there are 16 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=d4c5b22b471e != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

gHashTag
queen harvest: reseal the nine harvested specs, add the docs/now entry
4a3c6f7 
Closes #3508, closes #3515, closes #3524, closes #3525, closes #3530, closes #3531, closes #3534, closes #3536, closes #3538
@gHashTag
gHashTag force-pushed the queen/harvest-2026-09-10 branch from d3b9e49 to 4a3c6f7 Compare September 10, 2026 03:41
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-10 03:42:05 UTC

Summary

Status Count
Total Open PRs 16
PRs with Failing Checks 14
PRs with All Checks Green 2
READY 2
FAILING 14
PENDING 0
NO CHECKS YET 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=d4c5b22b471e != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit bff21b8 into master Sep 10, 2026
28 of 30 checks passed
@gHashTag
gHashTag deleted the queen/harvest-2026-09-10 branch September 10, 2026 04:27
@gHashTag

gHashTag commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Post-merge review: four behavioral defects

Reviewed the merged sources at bff21b85b206a0dd367876343e56dcd8312d81ba. These bodies/tests were introduced by this PR. Verification below uses source inspection and independent numerical/state replay, not execution of a generated t27 backend. The PR's parse/count acceptance is distinct from runtime conformance.

  1. [P1] SHA-256 compression uses incomplete Sigma functions. sha256.t27:183–196 implements each mixer as a single rotate. SHA-256 requires ROTR2 ^ ROTR13 ^ ROTR22, ROTR6 ^ ROTR11 ^ ROTR25, ROTR7 ^ ROTR18 ^ SHR3, and ROTR17 ^ ROTR19 ^ SHR10, respectively (FIPS 180-4, §4.1.2). Replaying the committed constants and arithmetic modulo 2^32 gives hash("") = cf263c8145381c527d523700bcd5375c85da3ac249439e815c781e49f2e12cec; the SHA-256 reference is e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855. Implement all four complete mixers and execute full-digest reference vectors, including empty input and abc.

  2. [P1] SHA-256 finalization mishandles message remainders of 56–63 bytes. In sha256.t27:79–101, remainder 56 produces zero_bytes = 0, so writing the length at offset 56 overwrites the just-written 0x80. Remainder 57 makes unsigned 56 - remainder underflow; subtracting 64 afterward does not repair it. Only one block is compressed. Emit the required additional padding block when the remainder is >=56 and test lengths 55, 56, 57, 63 and 64 against a reference. This is independent of the mixer defect (FIPS 180-4, §5.1.1).

  3. [P2] Exact GELU backward omits sqrt(pi) in the density normalization. gelu_activation.t27:71–73 divides exp(-x*x/2) by sqrt(2) instead of sqrt(2*pi). With approximate=false, input 1 and incoming gradient 1, the implemented formula gives 1.2702266885, while a central finite difference of this file's own exact forward (h=1e-5) gives 1.0833154706. At input -1 the corresponding values are -0.2702266885 and -0.0833154706. Correct the denominator and add nonzero finite-difference cases; the current exact-gradient tests at zero cannot detect this factor because the term is multiplied by x.

  4. [P2] The new wrap-around test contradicts the ring's capacity policy. ring_buffer.t27:162–170 requires three successful pushes into new(3). The constructor allocates three slots and is_full at line 63 reserves one empty slot. Replaying those transitions gives push results [true, true, false, false], then pops [1, 2], with head=2 and tail=2; the test requires [true, true, true, false] and tail=0. Decide whether public capacity means storage slots or usable entries, align the implementation/test, and exercise wrapping with pop followed by push.

Related original tasks: #3536 (SHA-256), #3530 (GELU), #3515 (ring buffer). Their parsing/count criteria may be satisfied, but these source-level counterexamples prevent treating the implementations as behaviorally verified. No code or issue states were changed by this review.

@gHashTag gHashTag mentioned this pull request Sep 13, 2026
Merged
gHashTag added a commit to gHashTag/BrowserOS that referenced this pull request Sep 13, 2026
@gHashTag gHashTag
feat(queen): give the bees t27c and let the review measure the commit (…
e1d8667 
…#479)

The review ran on the bee's own VERDICT block. Measured 2026-09-10
(gHashTag/t27#3560): of 34 finished branches, 20 did not parse, 4 parsed
with DISCARDED tokens, 1 regressed typecheck. Neither bee nor reviewer had
the compiler.

- Dockerfile: standalone t27c stage (rust:1-bookworm, sparse clone of
  bootstrap+gen, root Cargo.lock, no --locked), binary at
  /usr/local/bin/t27c, built ref at /usr/local/share/t27c/REF.
- queen-dispatch: witnessSpecs() reads each changed .t27 from the COMMIT
  (git show queen-N:file) and runs parse / parse-complete / typecheck as
  the bee; typecheck is a ratchet against TRIOS_REPO_REF, not a gate.
- queen-tick: machine verdicts join the bee's; unmet ones count against
  the send-back ceiling. Specs changed but no t27c => escalate, never
  accept. The brief names t27c and dictates the 'Closes #N' trailer the
  t27 L1 gate accepts.
- tests: queen-witness.test.ts (20 pass, 2 gated on queend).

Co-authored-by: gHashTag <oxicocicate35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment