Skip to content

fix(gates): read the pattern by vocabulary, not by how it spells a number - #3394

Merged
gHashTag merged 1 commit into
masterfrom
pattern-is-not-the-first-quote
Sep 6, 2026
Merged

fix(gates): read the pattern by vocabulary, not by how it spells a number#3394
gHashTag merged 1 commit into
masterfrom
pattern-is-not-the-first-quote

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Closes #3393

cli-tri has been red on master since 17:59 — green at 92a19608c, red at 52db4aacb. That commit (#3388) rewrote issue-gate.yml to strip fenced blocks and quotes from the body before grepping, which is a correct change, and the test that reads that file has failed ever since.

Two independent breakages in one line, each sufficient alone.

The gate's line used to open with its grep, so the first single-quoted span was the pattern. It now opens with printf '%s\\n%s\\n' — the extractor took the first span, found no reference in it, and abandoned the line instead of looking further along it. Taking the first span was never the rule; it was the first span happening to be the only one.

The line filter matched on #[0-9]+, which #3388 tightened to #[1-9][0-9]* to reject #0. The line then matched nothing, and the extractor reported that the gate states no pattern at all — which is what the test's expect panicked on.

Anchored on the gate's vocabulary (Closes?) rather than on how it spells a number: a number's spelling is the part of a pattern most likely to be tightened, and the keyword list is the part that identifies it. Every quoted span on the line is scanned.

824 tests pass. Mutation: breaking the vocabulary inside issue-gate.yml reddens the test, so it still reads the file it claims to read.

@gHashTag
gHashTag enabled auto-merge (squash) September 6, 2026 18:14
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-06 18:14:21 UTC

Summary

Status Count
Total Open PRs 16
PRs with Failing Checks 14
PRs with All Checks Green 2
READY 1
FAILING 14
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 14 + 0 + 0 = 15, and there are 16 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=745cf51f9c7e != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 02b7bec into master Sep 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli-tri red on master: the pattern extractor reads a spelling, not a vocabulary

1 participant