fix(ci): close four required-context defects, price the fifth - #3389
Merged
Conversation
gHashTag
enabled auto-merge (squash)
September 6, 2026 17:56
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
Contributor
PR DashboardGenerated at: 2026-09-06 17:57:12 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3388
Four of the five findings in #3337 are fixed here. Each was reproduced independently before it was acted on.
check-linked-issueCloses #0passed, andgh issue view 0answers "Could not resolve to an issue"#[1-9][0-9]*check-linked-issue>quote countedcheck--diff-filter=Amisses a rename, so a docs/now path whose content newly lands by rename never reaches the shape reader--no-renames, which makes git report D(old) + A(new)validatedecode("utf-8", "replace")turned invalid bytes into U+FFFD and then parsed the repaired textSix controls on the issue-gate logic, run before and after: a normal title reference passes; a body reference passes;
#0is refused; a reference inside a fence is refused; a reference in a quote is refused; and a real reference after a fence is still found — the stripping does not swallow what follows it.The fifth is not fixed, and this is why
validateaccepts bareInfinity, which CPython documents as "an extension to the JSON specification" and RFC 8259 has no literal for. The independent check is another language:node -e JSON.parse(...)rejects the file this gate passes.Blast radius measured: exactly one tracked file,
conformance/vectors/gf16_conformance_v0.json, six values. My first count said 20 files carryInfinity; 19 of those have it inside strings and parse fine.That file is generated by
conformance/vectors/gen_all_formats.pyand read bytools/wp18_selftest_gate.py. Its six values are genuine IEEE754 infinities. An encoding both sides agree on — a"Infinity"string,null, a sentinel — is a decision about conformance data, not about this reader.Shipping the stricter parse without that decision would leave a required context red and block every merge in the repository. So the defect is recorded in the code at the exact line, with its reason, and left for you.