Skip to content

fix(specs): a capitalised Const in 24 quoted types, against 374 lowercase (+6) - #3363

Merged
gHashTag merged 1 commit into
masterfrom
corpus-const-typo
Sep 6, 2026
Merged

fix(specs): a capitalised Const in 24 quoted types, against 374 lowercase (+6)#3363
gHashTag merged 1 commit into
masterfrom
corpus-const-typo

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Closes #3362

Twelve specs write their field types as quoted strings with a capitalised keyword:

tag        : "[]Const u8"
depends_on : "[]Const []Const u8"

The compiler strips the quotes and emits the content as a type, so rustc receives Vec<Const u8> and refuses it.

Why this is corrected rather than referred to you. The correct spelling []const appears 374 times in the same corpus; the capitalised form appears 24. That is a case typo in a keyword, not a semantic choice — there is no reading under which Const means something other than const here, and the corpus settles the spelling 374 to 24. Where a spec question has actually been a design decision ([]u32 = "[2, 2]", the empty field types, the Verilog entry-point contract) I have left it with you and said so.

Priced by hand first, on a sample of six: four compiled once corrected. Measured after, over the whole corpus: 346 → 352, zero regressions — two more than the sample predicted, because aho_corasick and regex also cleared.

+ tri/encoding/mime.t27          + tri/pipeline/workflow.t27
+ tri/graph/graph_bfs.t27        + tri/search/aho_corasick.t27
+ tri/pipeline/spec_writer.t27   + tri/search/regex.t27

The matcher is narrowed to []Const. A blanket Const const would have corrupted KwConst = 1 in compiler/lexer.t27 — a legitimate enum variant and the 25th occurrence. Verified intact afterwards.

html and xml keep failing on std.StringHashMap(...), a Zig standard-library type also written as a string. Different defect, untouched.

@gHashTag
gHashTag enabled auto-merge (squash) September 6, 2026 05:47
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-06 05:47:15 UTC

Summary

Status Count
Total Open PRs 16
PRs with Failing Checks 10
PRs with All Checks Green 6
READY 4
FAILING 10
PENDING 0
NO CHECKS YET 0

These columns do not partition: 4 + 10 + 0 + 0 = 14, and there are 16 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=23f03e8a97d5 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit 9a3940e into master Sep 6, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A capitalised Const in 24 quoted type strings, against 374 correct lowercase uses

1 participant