Skip to content

fix(rust): int, uint, float and double, which every neighbour already answers - #3334

Merged
gHashTag merged 2 commits into
masterfrom
int-float-did-not-travel
Sep 5, 2026
Merged

fix(rust): int, uint, float and double, which every neighbour already answers#3334
gHashTag merged 2 commits into
masterfrom
int-float-did-not-travel

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Closes #3323

t27_array_type_to_zig (compiler.rs:8349) carries "float" => "f64", "double" => "f64", "int" => "i32", "uint" => "u32" with a comment naming the same defect one backend over:

W591: float is not a Zig type. Same family as the f32/f64 gap W583 found on the C side — a scalar the corpus spells and the mapper never learned, so it passed through the other arm and reached the backend verbatim.

The C emitter matches "f16" | "f32" | "f64" | "float" | "double" in three places. The Rust mapper knew none of them.

The column does not move. Two pinned binaries of distinct hashes, 651 specs: 336 OK both sides, zero regressions.

What moves is the emission, and that is the claim being made here. 5 specs change their generated Rust — pub step_id: intpub step_id: i32, Vec<int>Vec<i32> — and cannot find type int/float`` was the FIRST rustc error on 3 of them and is now the first error on none. Their new first errors are K_TRUE and `Trit`, which is how the fix is known to have landed rather than assumed.

Deliberately narrow: capitalised Int and Float are not mapped. No neighbour answers those, so mapping them would be a decision rather than a transfer.

Method note. The first measurement was discarded: I rebuilt the compiler while the baseline run was still going — the ruler moved under the measurement — so both sides were re-run against binaries pinned before either started.

@gHashTag
gHashTag enabled auto-merge (squash) September 5, 2026 19:32
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-05 19:32:39 UTC

Summary

Status Count
Total Open PRs 17
PRs with Failing Checks 12
PRs with All Checks Green 5
READY 3
FAILING 12
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=6a8a89332bd9 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 826cefa into master Sep 5, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant