Skip to content

fix(hooks): run the barrier on merges, where the markers come from - #3319

Merged
gHashTag merged 1 commit into
masterfrom
barrier-runs-on-merges
Sep 5, 2026
Merged

fix(hooks): run the barrier on merges, where the markers come from#3319
gHashTag merged 1 commit into
masterfrom
barrier-runs-on-merges

Conversation

@gHashTag

@gHashTag gHashTag commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Closes #3318

Measured, git 2.50.1, marker hooks over five commit-creating events:

event pre-commit commit-msg
normal commit yes yes
--amend yes yes
--allow-empty yes yes
merge --no-ff no yes
cherry-pick no no

Every gate in tri hooks pre-commit — the conflict-marker refusal above all — was silent on the one commit type conflict markers actually come from.

git merge runs pre-merge-commit, and a non-zero exit stops the merge; verified, HEAD stayed on the pre-merge commit. The index at that moment holds the merge RESULT, which is exactly the operand the barrier reads since #3302 corrected it to --staged.

Controls, both sides. A merge whose result carries a marker exits 1, prints carries a conflict marker, and does not happen. A clean merge exits 0 and does.

cherry-pick runs neither hook and git offers none that could stop it. Stated as a known gap rather than papered over.

The class is the population of EVENTS — not the predicate, not the operand. Yesterday it was a push that could be a deletion (#3309); today a commit that could be a merge. Both found by asking "what else comes through here", neither by any control.

@gHashTag
gHashTag enabled auto-merge (squash) September 5, 2026 18:11
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-09-05 18:11:35 UTC

Summary

Status Count
Total Open PRs 13
PRs with Failing Checks 10
PRs with All Checks Green 3
READY 1
FAILING 10
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=ffccfa1a71cf != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit efdeb6c into master Sep 5, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The barrier does not run on merges, the commit type conflict markers come from

1 participant