Repository navigation
tri coverage: five coverage facts per spec, the rules in specs/tri/coverage/coverage.t27 - #11096
Merged
Merged
Conversation
…verage/coverage.t27; five negative-control gaps closed (Closes #11061) `tri coverage <pattern>...` prints one row per spec (tests, vacuous passes, negative controls by test name, seal MATCH, linked issue) and a total whose last line is `gaps G coverage N/D`, a fraction of counted facts and never a percentage. A fact that cannot be read counts as missing, so a blocked build is `unmeasured`. Exit 0 once printed, 1 on a gap with --strict, 2 when no spec matched (0/0 is not 100%). Every decision is in the spec, with 18 tests: the five facts, the closed list of seven negative-control name markers, the issue-link reader, the seal reader, the byte-exact row and total, the exit codes. The test-report reader and verdict are imported from specs/tri/test/report.t27 (what `tri test` uses), the byte writers from remote_job.t27; no body is copied (dupe_scan: the same 15 inherited names as master). The glue is cli/tri/src/coverage.rs (35 lines) and 4 lines in main.rs. Paid for by deleting scripts/trinity-pellis-pipeline/apply_defenses.py (144 lines, a one-off .tex patcher no file names). Gaps on the 29 specs of the analog, fpga, remote, lab and install groups, by this command's own rules: 5 before (all no-negative-control), 0 after, once the five edited seals are saved again. All five are closed in the specs: a test named for the negative control it already was (sar_kick, lab_t27b_report, prune), and a planted-fault test in each of the two PSP103 data specs. Closes #11061 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…verage/coverage.t27 (Closes #11061) Merge of master plus sealing, gates run on the merged tree with t27c from master: tests clean with vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
3 tasks
…parser drops are gone (Closes #11061) own-language refused cli/tri/src/coverage.rs as a new hand-written .rs; the same 33 lines and the 3 lines in main.rs now sit in the existing seals.rs. The corpus ratchet found 63 discarded tokens in coverage.t27: nine `use tri::test::report::...` lines, a use path through the keyword test, which the parser drops; they are removed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… census re-blessed if it moved (Closes #11061) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Open
3 tasks
…ser discard in the expectations ledger under #11101 (Closes #11061) Removing the nine use tri::test::report lines left the names undeclared (the spec no longer compiled). They are restored; the corpus ratchet entry (63 tokens, bdd-block-fallback, expires 2026-11-30) is the tracked state until the parser reads a use path through the keyword test. Seal re-saved: 18 tests pass, vacuous 0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
PR DashboardGenerated at: 2026-10-19 17:06:00 UTC
Summary
Seal Status
|
main.rs: the Coverage and Learn subcommands sit side by side. Both gates run before this commit: coverage.t27 tests clean (vacuous 0), seal verify MATCH, census gate checked. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
PR DashboardGenerated at: 2026-10-19 17:19:10 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11061
tri coverage: five coverage facts per spec, the rules in specs/tri/coverage/coverage.t27
Gates run on the merged tree (t27c from master): 10 spec(s) with tests clean and vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's (inherited red).
TEST specs/tri/coverage/coverage.t27 tests=[18] fail=[0] vacuous=[0]
TEST specs/analog/mos_psp103_data.t27 tests=[8] fail=[0] vacuous=[0]
TEST specs/analog/mos_psp103_50c_data.t27 tests=[4] fail=[0] vacuous=[0]
TEST specs/analog/sar_kick.t27 tests=[10] fail=[0] vacuous=[0]
TEST specs/lab/lab_t27b_report.t27 tests=[29] fail=[0] vacuous=[0]
TEST specs/lab/prune.t27 tests=[8] fail=[0] vacuous=[0]
TEST specs/analog/mos_psp103.t27 tests=[17] fail=[0] vacuous=[0]
TEST specs/analog/sar_adc.t27 tests=[15] fail=[0] vacuous=[0]
TEST specs/analog/sar_comparator_psp.t27 tests=[13] fail=[0] vacuous=[0]
TEST specs/lab/lab_t27b_ratchet.t27 tests=[14] fail=[0] vacuous=[0]
SEAL specs/tri/coverage/coverage.t27 :: all hashes MATCH
SEAL specs/analog/mos_psp103_data.t27 :: all hashes MATCH
SEAL specs/analog/mos_psp103_50c_data.t27 :: all hashes MATCH
SEAL specs/analog/sar_kick.t27 :: all hashes MATCH
SEAL specs/lab/lab_t27b_report.t27 :: all hashes MATCH
SEAL specs/lab/prune.t27 :: all hashes MATCH
SEAL specs/analog/mos_psp103.t27 :: all hashes MATCH
SEAL specs/analog/sar_adc.t27 :: all hashes MATCH
SEAL specs/analog/sar_comparator_psp.t27 :: all hashes MATCH
SEAL specs/lab/lab_t27b_ratchet.t27 :: all hashes MATCH
TYPES RATCHET: CLEAN
DUPE failing=15 extra-vs-master=[]
🤖 Generated with Claude Code