fix(queen): create the Queen schema before migrating; mend red server tests - #500
Merged
Merged
Conversation
…ests
The migrations failed on every fresh database: the pool pins search_path to
queenSchema() ('trios') and nothing created that schema, so a new
environment, a restore or CI got 'no schema has been selected to create in'
on every statement. runPgMigrations now runs CREATE SCHEMA IF NOT EXISTS
first; reproduced against PostgreSQL 16 (old code 2 fail, new code 3 pass),
and the live gate now inspects that schema instead of 'public'.
Tests that were red on every PR into this branch:
- queen-candidates: read the checkout it runs in, not /Users/playra/BrowserOS
- queen-salvage-guards: two tests need queend for a verdict, gated like
queen-adversarial-review; the fake gets a measurement budget of 1
- queen-salvage: the merge meant to conflict now has an identity; a CI
runner hostname with no domain made git refuse it before the index, and
the test now asserts the conflict (UU) actually happened
- navigation/windows: newer BrowserOS says 'Hidden windows are no longer
supported'; the skip helper accepts both wordings
- dom search_dom XPath: polls up to 5s instead of racing the page load
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Tests passed — 2377/2437
|
A second search_dom test (nodeId) raced the page load in CI the run after the XPath one was fixed. Both now go through searchUntil, which asks for up to five seconds until the answer carries what the test looks for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bug
runPgMigrationsfailed on any fresh database: the pool pinssearch_pathtoqueenSchema()and nothing created it (no schema has been selected to create in). NowCREATE SCHEMA IF NOT EXISTSfirst. Reproduced on PostgreSQL 16: old code 2 fail, new 3 pass.Tests red on every PR (#495-#499)
/Users/playra/BrowserOS-> this checkoutqueendfor a verdict ->it.if(queendPresent), as queen-adversarial-review doesUULocal: candidates 6/6, salvage 14/14, salvage-guards 13 pass + 2 skip, pglive 3/3 against PG16; tsc clean. Browser tests need CI.
🤖 Generated with Claude Code