Skip to content

Code Review #1

Description

@danceroutine
  • Your templates have a lot of overlap, consider using a templating language like Jinja2 to construct your templates dynamically. This also would allow you to extract the Firebase configuration out of the templates and into your python server code, which can then be pulled from a environment variable or secrets file.
  • I'm curious as to why you're passing in the nlp processor in various methods .py as opposed to simply importing it. Seems like an odd choice.
  • get_research_spec doesn't have a default return
  • Magic strings that can be reassigned to a variable
  • get_bio doesn't have a default return
  • make_data try except shouldn't be a naked except since it can hide other errors you might want to handle differently. Explicitly except the IndexError
  • link_extraction.py getPublications should be snake_case, and the repeated calls to targetText.replace can be thrown into a loop.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions