Repository navigation
Conversation
Read every file in spec/auto-instrumentation and the two shipped privacy.json copies, and fail if any line names an absolute /Volumes/ or /Users/ path.
No behaviour change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes internal references from comments and metadata in the auto-instrumentation spec and its copies, and adds a check that fails if an absolute local path (
/Volumes/or/Users/) appears in the spec folder or in the two shipped copies of the privacy catalog. No behaviour change.Why?
Such references do not belong in a public repository.
How was it tested?
Run in a clean Linux sandbox, at the base commit and at this branch:
@traceai/fi-core: the same 2,313 test ids run on both sides with the same outcomes. The only difference is 7 test titles renamed inround6.test.ts, which pass on both sides.@traceai/auto: the only difference between the two sides is the new path check, which passes.spec/auto-instrumentation/sync.pypasses on both sides).The launcher bundle did not build in that sandbox, at the base and at this branch alike, so the launcher tests that need it could not run there. This pull request's own checks run the real job.
pytestorvitest)ruff check/mypy/npm run typecheck/npm run lintall passChecklist
main: this branch targetsdev, like the other package fixesfeat:,fix:,docs:,chore:…)docs/VOCABULARY.mdNotes for reviewers
privacyRuntimePerfEquivalence.test.tschanges with the catalog text; the test logic is unchanged.fixtures/round6/folder name is structural and is left as it is.